From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12350 invoked by alias); 22 Mar 2018 20:43:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11754 invoked by uid 89); 22 Mar 2018 20:43:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 20:43:44 +0000 Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.183.87]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 60.6F.13895.E7514BA5; Thu, 22 Mar 2018 21:43:42 +0100 (CET) Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSHC023.ericsson.se (153.88.183.87) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 22 Mar 2018 21:43:41 +0100 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Thu, 22 Mar 2018 21:43:41 +0100 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Thu, 22 Mar 2018 21:43:41 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.63] (192.75.88.130) by BL0PR1501MB2001.namprd15.prod.outlook.com (2603:10b6:207:31::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.609.10; Thu, 22 Mar 2018 20:43:38 +0000 Subject: Re: [PATCH v4 01/10] Move tdesc header funcs to c file To: , CC: References: <20180322084429.26250-1-alan.hayward@arm.com> <20180322084429.26250-2-alan.hayward@arm.com> From: Simon Marchi Message-ID: Date: Thu, 22 Mar 2018 20:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322084429.26250-2-alan.hayward@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CY4PR1101CA0014.namprd11.prod.outlook.com (2603:10b6:910:15::24) To BL0PR1501MB2001.namprd15.prod.outlook.com (2603:10b6:207:31::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 78530585-6c1a-4d2e-f0c0-08d590359737 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BL0PR1501MB2001; X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2001;3:x5TII0UQISKnl0ThzmpqLRPHx3TpdWGASzJRkNyjHDxCdFmMSlS427A/OO7lhwRcCCuTalkn1y7be0QItuOvyx4qsYqR8yrYIKsGHEogEpfB8awtR82cYzridg8mXWzAWwU6fSZvJf3NlpJJLW+PCBpScAI23PA+cNQp7JUJZU66zSrYkcqc7uF7muKfzDRKROrAtLbfg4TFETPokFJ0VXcRaV2aN+3Gg3CZVFxNKbCnQ1y+It3pKshax97xTUE9;25:oX3Aqk/b/iSDn6yz7zbGyYWzb7Y1YCFUd81FfWp/np98/CKZXlZ1CCt/CAnqNSOZ7kmyb7XfTD0bAamqBB9h9ODM0JR/wK3b2A587W7/QWxI+DU92IVAEqZ6LfH9lJVV8a7lU29vxmgchNU7oKPlKBQRw1Jb0hNUyYLlbVXyg9jeEi7JnFIXyl3Zwzh5B6z6TsLcnQm9ED64/dmYMUBoXfhgOxAQKeyQSZPEvqzHqAV/yfhPw39/UBaHGtZYvjPgOVY8SJvhJNaCDk16SKW+R3BYeT1S4CVA8bFdnK5gyedBENzeWQEXGf6BOEaTg+vpeQhsV/33jp7crfmT94+w5A==;31:762+//hJrTKYhHUVreSRIoCsycje1rergp5h5mIA4n6ehcbEIuFAwL7lYrr2dH3pIGScM9W24zx04Ir+TFxtq9bVMhKymtSenqsRFAL1Id0bY/aMReAWSAnb27i7cWeUIk2SVzOM1DIqlJ78VcZ3fGO+LIy8u9d9ceLBPpedo9a48WFyj1wZZ7u4qdwWuRQI7DkjK+U2r9ciVeG3+AxGwtx/G/txuJYg9cQfgFHPQoE= X-MS-TrafficTypeDiagnostic: BL0PR1501MB2001: X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2001;20:qR3Q4pDCI5QrtlBaw7RH2QwbeV7akMrhlppzWrA78iZjJwBYqtHCy4q2YDF12oeSNcOcoacvhtmvuQcszlLhomfVGOb6ngT5lOEl28e+v3jFxXGxgF6zVkPnCgVPfMzP7zEx8cHLFBeJgkWi0GEpWOXlgcKKcAhgzl/49o2mDzy2Rv22t8v/RBkve0An1ZzQBtLfVaBLTjGwdgQSMoTWMUhvBLNQ4Z9kg9RjZu/RzGaY/BiBTn/9CrHh7lc15BQ8ZdTMKT4z+MdU5zKUsFVImq4WFip3jcLhSsRuDAOZjqncdKNFOV74RSzLYjipjB14NQ4Iqoo+BZbbLd1I5KRdPtX1LbozMv4nyKJdfu99rxtaB8qsFH/Y1IJDAxKyMPVDiUdv6Sy3vX4ji8oKD6d61WGGIaRXyASvr0KRe2Wz/zdyhK6gJIGmzr8a7jQc8nij2oXlhWx0kdfoJWCaBCEVj6DpbormXVakjR8ftvdDNeFjZs7ZFApXY5a3oCfxN1SZ;4:mABeF4OgwYBZ/ZHQF2xee7Vu+FaH4EsYnU0oB8UmjSmsZWy82vKTUCtqLA8GbrdnuLuyGAnhAD9e3h4ITmL/kU/NbRhmlSttJyOJFoOslmlXGjz9Av9sgSUP23IBDDNUPbV+vDQRiaA3l1cOWjVN9OtZasy7y89mGWAx2JSo2fKf0vY7NuTo1YbMYqXUx2YCMTtx7ypw9HQ7If62Yg83GAxEHBO1L3b3Dt/K5t/JTWItTcpm1ecj1bk0fRmEfexzUWJktDYAl8oBU+6xNOnb4V9OTBAk6pezCToY3DL7FqyHMg+QeyyL+d7SGYJ21qwi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(10201501046)(3002001)(6041310)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:BL0PR1501MB2001;BCL:0;PCL:0;RULEID:;SRVR:BL0PR1501MB2001; X-Forefront-PRVS: 0619D53754 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(376002)(346002)(39380400002)(366004)(39860400002)(377424004)(199004)(189003)(49976009)(105586002)(65826007)(229853002)(5660300001)(31696002)(65806001)(65956001)(66066001)(31686004)(47776003)(316002)(8936002)(64126003)(76176011)(230700001)(25786009)(4326008)(3846002)(6116002)(8676002)(81166006)(2906002)(81156014)(106356001)(478600001)(97736004)(68736007)(50466002)(305945005)(7736002)(6666003)(36756003)(58126008)(52116002)(52146003)(2486003)(23676004)(6246003)(53936002)(16576012)(6486002)(446003)(186003)(16526019)(26005)(86362001)(53546011)(11346002)(386003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR1501MB2001;H:[142.133.49.63];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDBQUjE1MDFNQjIwMDE7MjM6ZmpoT211bXRrWGcyS1kxTW8xYnMrWkww?= =?utf-8?B?WmpQZWQvKzJFQzg3dHB6Wnl5OUdNcjZLRzNxdWF4UzkvOW1pNVViUktOcFk4?= =?utf-8?B?TTNVQnNIVHFsK0UyckNpQUFUc3JXWXU3cWE3cGFESHlrcUtnL0t0YVh6bW9U?= =?utf-8?B?QjF0YmxNUi9LeVI3aUswb1VCb2NZVWxtdllCZ3hycjltT1lkYlp5RHVlSG5s?= =?utf-8?B?dnFVN2duOTVIczI1Z1BFQ1NzbjZSSzlPMUVZSld2dkNJcG41eTZjV3JuYTMr?= =?utf-8?B?VTB4elhscU9VWlJhQkpoMEtYdlNNeW9RZmVkYmdqYS95dDJMYUx5Z0RSZHFO?= =?utf-8?B?alpYQlNUaUR3d1pJQnBCQVNJdDJtTmlOK3Jqbkljem9POGh5SWxsbmlnbE5O?= =?utf-8?B?c1FwdHVjSjdUNmozZVRTZ2sxME50bDBXTHFHWS9vbHF6eGZnTzhPQXVBYzNa?= =?utf-8?B?TGJoUEovZVdxN1kvZzh2dytDdStnbW80TUxuRFdrRzhORjVxM2I4eUVwRGpa?= =?utf-8?B?TmlpcmdlbTVSKzRqeXZzanEyMkJzckdVc1d3dlRhTjRJOFlHa2dWczRMd2FQ?= =?utf-8?B?eHRwRS9WMlBqR1BNVlI5MzV0T3h0Z0tEU0VEWnNtMTJHak10NEFvWUM1QWQr?= =?utf-8?B?M201SXhUeVR6Ym9MZzl3UDhNV2FTT3JNMWJEblVKc1RsdWI1RWFrM0pjMU9h?= =?utf-8?B?Ym54YTFHWDRHeTBIRzNmNHlEQzVTeE5VNk1WOEJMRnBON2VsWlllWVFhM1hG?= =?utf-8?B?Q1haQlRoUEFNcE5zQUtJK3gwd1Ird3lMZnZMbThKUVlNWlFWcytnbnhiMHg5?= =?utf-8?B?MU9xQzdpTGNmckpMMm5LUHBLSjJXQlZaTEhhenhrbEU3cUxpZENIOU0yWDJE?= =?utf-8?B?aUhzTzVQOVVWeCt1d3hqWG0wQU5UczgweGVob3BXVUFiU01DeVNQNUVQc0Yr?= =?utf-8?B?Y3dDZTJXdjJzSkwzMEVYQXdlRXR1MG5GcmtYdXpnZmJWU21YYXVlSk5XdmtT?= =?utf-8?B?RmtaTHY4ZlZrWnRhOFZ1RG5YVXRaSFZpZmJCSFJUd2VxNnFKN0JjSzdRQ0Iz?= =?utf-8?B?UWpGWWppNW1HVzM0Vmx2UmVYWkZDVDBsWkh2YlZ5eHI4UDFuSCtIY3VsNGhI?= =?utf-8?B?YWpvVWhFU3oyNTlUbjZqK3VtL3lSRUlkTWxmb0lpd1lFYUdwWXZvUkZlYVBq?= =?utf-8?B?VnFRcFczS3VEeTlVWDFTN25CYUZXVjFKVjZ0K0xXSGVLQTExY1Z4dTRXVXRB?= =?utf-8?B?Mys3cG9RRGZwcmhCb1VqNFVrOElsT3ZPd3dyc1k5STlIMVpPaEtnQUgzVVFV?= =?utf-8?B?MmZnVEl6QkpvaHEyRGR1UFJOaVVYMFZHTlhFQ1dGeVZzWnMwZ3FUZUs3UERT?= =?utf-8?B?K1NEZ1pJbTl6cjFHSDBrQmpOSUJVRnQ2TzZPZGdVeVJnOWdTcU9NSzkvNE96?= =?utf-8?B?aXdxSzZ6Zm10UmZjS0FFcDJTUDN3RjhaeVdHbWFQYm5yczczakRxMWRXM0FD?= =?utf-8?B?KzZLWW16VzRydnBnOTJsc1dYZVRzeFQvSDdtNmZFYnI0WjNIWUc5ZndBVW4r?= =?utf-8?B?RDhyUDdLL1pMc3YrQld0dlFLWjBObyt1WXZ0ZDg3b0N1U00yYjQzWmtqdjNp?= =?utf-8?B?eHRUSytlREwzYkllRklHWnY5YUZkRnNhUEV3UWtrSGlPUmdaUExmVWhwaVNM?= =?utf-8?B?ZFFSNEQ4YjBsaFQ3ZTlxWktUYk1CSUxQRlM2YmF0bDdobUFhalNDYTh4WFZw?= =?utf-8?B?NXJGcGUvU0xMaVhQeE1Da0M0TWVGaUczcGZFNnZRcFZvaHF4RUVJQlgrcnhM?= =?utf-8?B?N1F6OUNGSVMvcGVWWHA2a2E2dGZFTGxBMzRieFNvUG9WdU9qaEFwYXdmQXZi?= =?utf-8?Q?p4WXuskOALfE4=3D?= X-Microsoft-Antispam-Message-Info: IukBv0RvBh2Pb2Dl8W2zYmoDL0+QJC8/PqkL1y70du3iu30O0+WmOgE/UeqbG4I3vTx7aSBCYWD4HROEn6hH+ap8Njetj5pew5LqQy2sncc11M+f+Bme6hTa7744Vt+LEBrba8+XVf5ieB9Hbfppyw7m39K1j3SO3FlebNyEMDaVofRRj+5Z0uN31oMYj2Gc X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2001;6:CXz6xZcyVdIsLFiigVCbGkw/I0eclDMme5wf3PsRKNsM0PXY7s3s0RqRSjUUliWEy05TI/EvkLRxowrAD0/JDgEcrYms4lx1HkSVufuXOpHSSrAETJ4geHh6gWbLSm7+IIFJphJKD082GIyY4phtUZSGpASfK95yexniX8+LZag3+Brk3LBqotCcvTNIXxf6XEuKExbG21XZkVvAjk75lcAStfNLAtYduneFwWC1WwaQFEJuAFWBaW3zyUPORqTJeJ3AFVjq2MmDxh1afw5/yaXcU1OXaoOmdvMkgDL1v4Je+clASLwdlRzS9WmoeOV7oIKRTvGFm8FBJmxJ+0nO/86os6JUnEXSfDQjizEdKAnVkDjiuvxlW5WKe/3ampNQFBfU1tLHbuA4iULdce49wW+UbByBlDCKHvTPNc2TytM9md4ZpOoQBhS24xBPN01eq4Mof6l+aBm+k97ltgytEA==;5:Ly3C9mtHdTzcMIWf+cF47PIzgYVzfui+lNaKr+W4/G6kvB/qXhUtquTeMY52y/7YAHJ0YuZtRBgdOTM515cUBvqDEMRW6KSKYQ7QPBj23holdQCYEEHUUMmEbNuxz0eJK8XFIOm/Dcie4ORQswuY+YVMT8qqiL73q6c3HSiIbls=;24:Y0GlInCSoY1Phn0NIbsD3Ar9mYHclrC/N5rUoxLLpbcsAafjwt/9TTjqEWeI/+pz/MAFAemhcqRnCC7bm159Up9mjVM7KP+xQQiwiJlnLVU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2001;7:htOlxQRhy5e+ihd90BDnfWPoPd4U75h0x7MkJOW6GW4S9ykXwt5San/p2CJSGtSyZQERvkWXrSkCvqVIG1m2ZMYC60vV+N3Mwu7HOaFs18zIvJJgkLSGe3NgyLBI9UX5kn/zhlNRAXXxuh+PXKHD/a4zQdlb0NoUqGKKAqfjsPIBj60A+oVvoEl2x5iVFDPocUDs9LGrKQPVR8aRcn/3GodJVyK6+I+8P4PKAh2uBnx1tXr5wWeQTbiowCc7b1Qe X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2018 20:43:38.1860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78530585-6c1a-4d2e-f0c0-08d590359737 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR1501MB2001 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00431.txt.bz2 On 2018-03-22 04:44 AM, alan.hayward@arm.com wrote: > From: Alan Hayward > > Move the destructor and equals operator for gdbserver tdesc from the .h > to the .c file. Both functions are too long to be inlined and make the > header look messy. Patch does not change any functionality. > Patch identical to V3 version. > > 2018-03-21 Alan Hayward > > gdbserver/ > * tdesc.c (target_desc::~target_desc): Move to here. > (target_desc::operator==): Likewise. > * tdesc.h (target_desc::~target_desc): Move from here. > (target_desc::operator==): Likewise. This patch LGTM, feel free to push it by itself, it will be one less patch to worry about. Simon