From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2078.outbound.protection.outlook.com [40.107.22.78]) by sourceware.org (Postfix) with ESMTPS id 77B293857353 for ; Fri, 9 Jun 2023 10:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77B293857353 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bV0s8WsoUOE/wOu1f3rSw+wrPd0Qet1T3vKzOp70TRQ=; b=49p12PKglSeSckSMCKraUMmssechI5DFlUwbaim1No1rFt761sHTlkeDOFYSKjrw6T5ubnJsNgQle/R7JpiV9bn3yLpIM7co3iSc1StJZ+EZpHh6OLJoPxqyuBPdFpJuUuf+xyP8mK7pth9yn5+4NNVDKXaBaDhic4bQn1Gc1Wo= Received: from AS9PR05CA0163.eurprd05.prod.outlook.com (2603:10a6:20b:496::23) by DU0PR08MB7882.eurprd08.prod.outlook.com (2603:10a6:10:3b2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.42; Fri, 9 Jun 2023 10:29:42 +0000 Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:496:cafe::eb) by AS9PR05CA0163.outlook.office365.com (2603:10a6:20b:496::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.27 via Frontend Transport; Fri, 9 Jun 2023 10:29:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.24 via Frontend Transport; Fri, 9 Jun 2023 10:29:42 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Fri, 09 Jun 2023 10:29:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 20eff7c6ee435561 X-CR-MTA-TID: 64aa7808 Received: from 1d70a6f93c00.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 517ADB36-45ED-4B7D-A1C8-27575106D35E.1; Fri, 09 Jun 2023 10:29:35 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1d70a6f93c00.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Jun 2023 10:29:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A65eWnydny0XrAAtEBBj3XEtuv0weVZmoP2ofoFsp0Atx2T+EALeX8vrfbWONF4YEuDj97pr/0js1ElocLPyeZdY4IBOS2O4q/1+w/YsAfVoas0Bxjs9+9ib8ggYvIwSNtHBKxCZRygemIs+J2SnFpYs+8mELJuWhKBuaAHHVanVtVPmWFGpx9dH5CJFY8Y9dUXlt8tNElyeTblnshKpRQYGL596NY+LYjqMB4pvDlsiBnStujoHhuWYwKAWd6bOXqk4vovRvAfolFiPsL2zEgOXhExbe7F8T0owH5JwIqT6z9ClUTRASL5hNnsPkFAbfEvMDaauJN6gLEXdKs/Aaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bV0s8WsoUOE/wOu1f3rSw+wrPd0Qet1T3vKzOp70TRQ=; b=nlic/2raCAH6Ld7weWnop+z+J5a9Vn0L/wWCx1Rx0PsQMlapgmPvCF/l6s4TNh2AojIZgH7U6kS6bNVzUBKBDJSFH7tGyFVHLyR0tBXNibMgFqUBXSivAcBUGQZxettzua9nNEDf7ISrk1/KAO76+9Lj3kk8ctCDj8WIdhqLVjXAQGMpIjGZU4am6Wg/lZXncZUv0LrWqCxEMKR8ZFQbvzhq4ul0OI7t1JEpXDvcteMFLq4xwtz0CMC9gGJQItpCpHG2g/nxj2TF8iH97X0N0T4LOEURGSLvYW9O784IMDDbvAFZtJVNVk0hqzgmkq9gJEATRNDIxhl8YXRMJdyYtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bV0s8WsoUOE/wOu1f3rSw+wrPd0Qet1T3vKzOp70TRQ=; b=49p12PKglSeSckSMCKraUMmssechI5DFlUwbaim1No1rFt761sHTlkeDOFYSKjrw6T5ubnJsNgQle/R7JpiV9bn3yLpIM7co3iSc1StJZ+EZpHh6OLJoPxqyuBPdFpJuUuf+xyP8mK7pth9yn5+4NNVDKXaBaDhic4bQn1Gc1Wo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB8370.eurprd08.prod.outlook.com (2603:10a6:20b:56b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.39; Fri, 9 Jun 2023 10:29:32 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c6b8:4dc0:6f9:7f40]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c6b8:4dc0:6f9:7f40%3]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023 10:29:32 +0000 Message-ID: Date: Fri, 9 Jun 2023 11:29:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] gdb/testsuite: Testing with the armflang compiler To: Richard Bunt , gdb-patches@sourceware.org References: <20230609101605.545246-1-richard.bunt@linaro.org> Content-Language: en-US From: Luis Machado In-Reply-To: <20230609101605.545246-1-richard.bunt@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0476.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::13) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB8370:EE_|AM7EUR03FT059:EE_|DU0PR08MB7882:EE_ X-MS-Office365-Filtering-Correlation-Id: 11ca4ddb-04ff-4a30-6873-08db68d46fde x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hiLFikP8/MFZQ40EA29Lt14/JK/ejl202ruu0smS+NKMXOicvRITGuAAdV61WUJq8MFYmeJ968JK5yu7w/A3exIwoj+K3WBDuWxMyBMK8sh9pxCfHXX7dpGN05h9gD36f8Kxd4NQCI3sz3SPu5PfFVKYX8zlL2hGq4QjghrdJ+gPTAF4ez4qR6aJWukjVcclOnWJh5DX8egHYUNyHqF94TWfoCqpXbN19wpzc6pfsM5aa0lwoEmtSoo0G/y/ee0BiZt+n7PsTwPGI8viZ/XSYz97ykS+hldFuRc88+z/xv9Tkl2dpZ+JJg41l5KXtK3/bWZz37+944w7w1AwTWsyVheY6Fmgr4VNEwOlH8ljdct/VGTXpVkUpT3z968c56YN77jD3033W9BLlsvdya5AepMdq49ZmSE5cqa8P0mVfPllROssQ4BG4Mb7d4WiePKbL96OM1EosfPV+qnO9E4lpBaXOG/Tiw0oaxVCize+xNJ4AavlN/dIxM3rkfsv5TT3U451x2jLeMYsfNKkMcVhk2wf6SxD/7PCCfwKAeGa3cv2Lqui16YzTQ6sQQjz9T3Gf7iHSwOewQ+pVrNaHTqJvdDn+e1GZccfsUT3T1BfNU8v+Y7HPyK3d8/Ikxwd0l2DsHXeZUuXc+YxzCiNU4A+5Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199021)(2616005)(36756003)(31696002)(86362001)(316002)(478600001)(66556008)(66476007)(66946007)(6486002)(8676002)(5660300002)(8936002)(41300700001)(2906002)(44832011)(38100700002)(53546011)(6506007)(6512007)(186003)(26005)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8370 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a1d1dc65-e792-4ab7-b98a-08db68d469da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MqNvD4X377pqopCVkBVYdl6IGCv70auGOpwfzFtcNP1Xm9HO00+FWIozNRjdP8l9Pvg6DJ66oxt7a/VRDQmW0g5RTsuJKsQmykd2GQWrgg4EE594PSBUEbkYFHJPi/NfX7tHd81Kd+hCW7zWbsTb7mPw0WwOzC59qkocRvLGTNAfO/DK/+GCKYN7NwDjBFNQ0EfNlxBhKPKeYspNw09b42VQJ76pj3wZjgs3cJgZwfMGoYD0rSNOEaMlLjiOeQOUv18Ursv1l4wTkUpr3i/t8cJytVy2kKZkpLqSsqsLdNMzto7R8vAHVvB+mQu/u/eDtn/f12HTCiRN5Q0IgObVxDz8naJmSXZWioHZrL1X7sl6ZpfqPD7SADcrOK7gRlCTwxMN+AEUyIQVtAwP911mi5xFAV3EL8xx9d7wjuebO0PT9mccPp2ZB+qWT8j3MnWC8ECyaDlsup2Cbvd7HhXvYdpA6w0PQhIKpzZXGDaKo41/OP1slzGTAhCFhNnyQrJU6AjGha8zKLT0Jbkkw+NJacg2f5ny2AuKyfVA2dTjpUwTrEgK42gOqb+rl71fee3bjcO1nkz9oDn51PPUeMQWXHCRSPwbD2rqEdz8kx4fx3AnX1dMwHSjY3cFbQpXKdSlwTKOwxe80HPSTMOv0sEx/QzEraVTcFiBlVSK7VTvIjA9jB7zajIs/mQvj8w2knDOC0z2HEtWdmat8b+YbIYkoPXKpmHSTj924/d/sCkBm5w7pIiKuEdoI+tndiig2MWSGc16lyM2qHLdQ0QQ1jqykQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(316002)(40460700003)(6486002)(41300700001)(336012)(83380400001)(2616005)(86362001)(82310400005)(31696002)(36860700001)(47076005)(53546011)(186003)(6512007)(6506007)(26005)(44832011)(2906002)(81166007)(356005)(82740400003)(40480700001)(5660300002)(8936002)(36756003)(8676002)(70586007)(70206006)(478600001)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 10:29:42.1790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11ca4ddb-04ff-4a30-6873-08db68d46fde X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7882 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/9/23 11:16, Richard Bunt via Gdb-patches wrote: > Currently the Fortran test suite does not run with armflang because the > compiler detection fails. This in turn means fortran_runto_main does not > know which main method to use to start a test case. > > Fortran compiler detection was added in 44d469c5f85; however, the commit > message notes that it was not tested with armflang. > > This commit tests and fixes up a minor issue to get the detection > working. > > The goal here is to get the tests running and preventing further > regressions during future work. This change does not do anything to fix > existing failures. > >>>From what I can understand, the auto detection leverages the > preprocessor to extract the Fortran compiler identity from the defines. > This preprocessor output is then evaluated by the test suite to import > these defines. > > In the case of armflang, this evaluation step is disrupted by the > presence of the following warning: > > $ armflang -E -fdiagnostics-color=never testsuite/lib/compiler.F90 -o compiler.exp > $ clang-13: warning: argument unused during compilation: '-fdiagnostics-color=never' [-Wunused-command-line-argument] > > The evaluation logic is already set up to filter this warning, but the > prefix differs. > > This commit fixes the issue by updating the filter to exclude the > armflang flavour of warning. > > gdb.fortran regression tests run with GNU, Intel and Intel LLVM. No > regressions detected. > > The gdb.fortran test results with ACfL 23.04.1 are as follows. > > Before: > > # of expected passes 560 > # of unexpected failures 113 > # of unresolved testcases 2 > # of untested testcases 5 > # of duplicate test names 2 > > After: > > # of expected passes 5388 > # of unexpected failures 628 > # of known failures 10 > # of untested testcases 8 > # of unsupported tests 5 > # of duplicate test names 5 > > As can be seen from the above, there are now considerably more passing > assertions. > > --- > gdb/testsuite/lib/gdb.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 220640210cd..b1d5ef3fef1 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4531,7 +4531,7 @@ proc get_compiler_info {{language "c"}} { > # eval this line > verbose "get_compiler_info: $cppline" 2 > eval "$cppline" > - } elseif { [ regexp "flang.*warning.*'-fdiagnostics-color=never'" "$cppline"] } { > + } elseif { [ regexp "\[fc\]lang.*warning.*'-fdiagnostics-color=never'" "$cppline"] } { > # Both flang preprocessors (llvm flang and classic flang) print a > # warning for the unused -fdiagnostics-color=never, so we skip this > # output line here. Is my understanding correct that this is now handling both flang and clang? And clang is output for the armflang compiler? It looks OK to me, but you might want to add an explanation, in a comment, about why we're trying to handle clang for a fortran compiler. Reviewed-By: Luis Machado