From: Tomas Vanek <vanekt@volny.cz>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
gdb-patches@sourceware.org
Cc: luis.machado@arm.com
Subject: Re: [PATCH 2/3] gdb/arm: Ensure that stack pointers are in sync
Date: Fri, 4 Nov 2022 18:31:25 +0100 [thread overview]
Message-ID: <a7461b00-ea40-d3bf-859d-0927dad10c67@volny.cz> (raw)
In-Reply-To: <20221104144438.2786801-3-torbjorn.svensson@foss.st.com>
Torbjorn,
thanks for addressing the issue so fast!
With two fixes commented inline the patch series resolves [Bug tdep/29738]
Tomas
On 04/11/2022 15:44, Torbjörn SVENSSON wrote:
> Without this patch, sp might be secure, but msp or psp is non-secure
> (this state can not happen in the hardware).
>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gdb/arm-tdep.c | 86 ++++++++++++++++++++++++++++++++++----------------
> 1 file changed, 58 insertions(+), 28 deletions(-)
>
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index 124a94dc87d..c011b2aa973 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -324,20 +324,6 @@ reconstruct_t_bit(struct gdbarch *gdbarch, CORE_ADDR lr, ULONGEST psr)
> return psr;
> }
>
> -/* Initialize stack pointers, and flag the active one. */
> -
> -static inline void
> -arm_cache_init_sp (int regnum, CORE_ADDR* member,
> - struct arm_prologue_cache *cache,
> - frame_info_ptr frame)
> -{
> - CORE_ADDR val = get_frame_register_unsigned (frame, regnum);
> - if (val == cache->sp)
> - cache->active_sp_regnum = regnum;
> -
> - *member = val;
> -}
> -
> /* Initialize CACHE fields for which zero is not adequate (CACHE is
> expected to have been ZALLOC'ed before calling this function). */
>
> @@ -362,34 +348,78 @@ arm_cache_init (struct arm_prologue_cache *cache, frame_info_ptr frame)
>
> if (tdep->have_sec_ext)
> {
> - CORE_ADDR msp_val = get_frame_register_unsigned (frame, tdep->m_profile_msp_regnum);
> - CORE_ADDR psp_val = get_frame_register_unsigned (frame, tdep->m_profile_psp_regnum);
> -
> - arm_cache_init_sp (tdep->m_profile_msp_s_regnum, &cache->msp_s, cache, frame);
> - arm_cache_init_sp (tdep->m_profile_psp_s_regnum, &cache->psp_s, cache, frame);
> - arm_cache_init_sp (tdep->m_profile_msp_ns_regnum, &cache->msp_ns, cache, frame);
> - arm_cache_init_sp (tdep->m_profile_psp_ns_regnum, &cache->psp_ns, cache, frame);
> -
> + const CORE_ADDR msp_val
> + = get_frame_register_unsigned (frame, tdep->m_profile_msp_regnum);
> + const CORE_ADDR psp_val
> + = get_frame_register_unsigned (frame, tdep->m_profile_psp_regnum);
> +
> + cache->msp_s
> + = get_frame_register_unsigned (frame, tdep->m_profile_msp_s_regnum);
> + cache->msp_ns
> + = get_frame_register_unsigned (frame, tdep->m_profile_msp_ns_regnum);
> + cache->psp_s
> + = get_frame_register_unsigned (frame, tdep->m_profile_psp_s_regnum);
> + cache->psp_ns
> + = get_frame_register_unsigned (frame, tdep->m_profile_psp_ns_regnum);
> +
> + /* Identify what msp is alias for (msp_s or msp_ns). */
> if (msp_val == cache->msp_s)
> cache->active_msp_regnum = tdep->m_profile_msp_s_regnum;
> else if (msp_val == cache->msp_ns)
> cache->active_msp_regnum = tdep->m_profile_msp_ns_regnum;
> + else
> + {
> + warning (_("Invalid state, unable to determine msp alias."));
> + cache->active_msp_regnum = tdep->m_profile_msp_s_regnum;
> + }
> +
> + /* Identify what psp is alias for (psp_s or psp_ns). */
> if (psp_val == cache->psp_s)
> cache->active_psp_regnum = tdep->m_profile_psp_s_regnum;
> else if (psp_val == cache->psp_ns)
> cache->active_psp_regnum = tdep->m_profile_psp_ns_regnum;
> + else
> + {
> + warning (_("Invalid state, unable to determine psp alias."));
> + cache->active_psp_regnum = tdep->m_profile_psp_s_regnum;
> + }
>
> - /* Use MSP_S as default stack pointer. */
> - if (cache->active_sp_regnum == ARM_SP_REGNUM)
> - cache->active_sp_regnum = tdep->m_profile_msp_s_regnum;
> + /* Identify what sp is alias for (msp_s, msp_ns, psp_s or psp_ns). */
> + if (msp_val == cache->sp)
> + cache->active_sp_regnum = cache->active_msp_regnum;
> + else if (psp_val == cache->sp)
> + cache->active_sp_regnum = cache->active_psp_regnum;
> + else
> + {
> + warning (_("Invalid state, unable to determine sp alias."));
> + cache->active_sp_regnum = cache->active_msp_regnum;
> + }
> }
> else if (tdep->is_m)
> {
> - arm_cache_init_sp (tdep->m_profile_msp_regnum, &cache->msp_s, cache, frame);
> - arm_cache_init_sp (tdep->m_profile_psp_regnum, &cache->psp_s, cache, frame);
> + cache->msp_s
> + = get_frame_register_unsigned (frame, tdep->m_profile_msp_s_regnum);
Should use tdep->m_profile_msp_regnum,
tdep->m_profile_msp_s_regnum is not initialized on M-profile without sec ext
> + cache->psp_s
> + = get_frame_register_unsigned (frame, tdep->m_profile_psp_s_regnum);
And here similarly tdep->m_profile_psp_regnum
> +
> + /* Identify what sp is alias for (msp or psp). */
> + if (cache->msp_s == cache->sp)
> + cache->active_sp_regnum = tdep->m_profile_msp_regnum;
> + else if (cache->psp_s == cache->sp)
> + cache->active_sp_regnum = tdep->m_profile_psp_regnum;
> + else
> + {
> + warning (_("Invalid state, unable to determine sp alias."));
> + cache->active_sp_regnum = tdep->m_profile_msp_regnum;
> + }
> }
> else
> - arm_cache_init_sp (ARM_SP_REGNUM, &cache->msp_s, cache, frame);
> + {
> + cache->msp_s
> + = get_frame_register_unsigned (frame, ARM_SP_REGNUM);
> +
> + cache->active_sp_regnum = ARM_SP_REGNUM;
> + }
> }
>
> /* Return the requested stack pointer value (in REGNUM), taking into
next prev parent reply other threads:[~2022-11-04 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 14:44 [PATCH 0/3] gdb/arm: Fixes for Cortex-M stack unwinding Torbjörn SVENSSON
2022-11-04 14:44 ` [PATCH 1/3] gdb/arm: Update active msp/psp when switching stack Torbjörn SVENSSON
2022-11-04 14:44 ` [PATCH 2/3] gdb/arm: Ensure that stack pointers are in sync Torbjörn SVENSSON
2022-11-04 17:31 ` Tomas Vanek [this message]
2022-11-07 17:27 ` Torbjorn SVENSSON
2022-11-04 14:44 ` [PATCH 3/3] gdb/arm: PR 29738 Cache value for stack pointers for dwarf2 frames Torbjörn SVENSSON
2022-11-11 9:15 ` Luis Machado
2022-11-11 10:27 ` Tomas Vanek
2022-11-12 19:54 ` Torbjorn SVENSSON
2022-11-14 10:46 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7461b00-ea40-d3bf-859d-0927dad10c67@volny.cz \
--to=vanekt@volny.cz \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).