From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B6DC338983A3 for ; Tue, 15 Nov 2022 15:49:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6DC338983A3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2AFFndlA010439 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 10:49:43 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2AFFndlA010439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1668527384; bh=eXC5CTygQFMHrEqRo5rNXyt+H5oy/UfNUfcYDTTQueE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=nRYVGdFIzplF5MQLLgYwaBvT77BPY0ceaWuDk/VlJW52c17YRAK7zOrWf3YOKS7Ej G2AYIaI5Px4BgO1T0jmKdrFq5b7fZksnnvSj4fSI14tv5gEdLb/2UAfa4aQigdglE/ qluMnwuq18hp8bxkcjD+yW8fC4KYa/x019dMzbz0= Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1B26A1E0D3; Tue, 15 Nov 2022 10:49:38 -0500 (EST) Message-ID: Date: Tue, 15 Nov 2022 10:49:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] gdb/testsuite: get_set_option_choices: expect \r\n after each item Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org References: <20221114151416.372074-1-simon.marchi@polymtl.ca> <3c8249a8-4cc3-8fcb-05fa-bb70a2f55209@suse.de> <33cbb0f0-72b2-7202-db84-2e3def9b126c@polymtl.ca> <52209cc2-3082-4f3e-e5a7-57382baa6e11@suse.de> From: Simon Marchi In-Reply-To: <52209cc2-3082-4f3e-e5a7-57382baa6e11@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 15 Nov 2022 15:49:39 +0000 X-Spam-Status: No, score=-3032.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Yep, more strict matching is ok. > > LGTM. Thanks. I pushed it, but actually I went with this, since we're not using -wrap anyway. I think it's a bit less cryptic than the lookahead version: with_set max-completions unlimited { gdb_test_multiple $cmd $test { -re "^[string_to_regexp $cmd]\r\n" { exp_continue } -re "^$set_cmd (\[^\r\n\]+)\r\n" { lappend values $expect_out(1,string) exp_continue } -re "^$::gdb_prompt $" { pass $gdb_test_name } } } Simon