RE: [PATCH ver3] gdb: Add PowerPC support to gdb.dwarf2/frame-inlined-in-outer-frame.exp

[Carl Love <cel@us.ibm.com>]

Simon:

On Mon, 2021-12-06 at 11:43 -0500, Simon Marchi wrote:
> > +#if defined __powerpc64__
> > +#  if _CALL_ELF == 2
> > +.abiversion 2   /* Tell gdb what ELF version to use. */
> > +.global _start
> > +_start:
> > +#  else
> > +.abiversion 1   /* Tell gdb what ELF version to use. */
> > +.align 2
> > +.global _start
> > +.section ".opd", "aw"
> > +.align 3
> > +_start:
> > +.quad ._start,.TOC.@tocbase,0
> > +.previous
> > +.type ._start,@function
> > +._start:
> > +#  endif
> > +#else
> >   .global _start
> >   _start:
> > +#endif
> 
> My only question is whether these two lines:
> 
>   .global _start
>   _start:
> 
> could be kept unconditional, and just not put in the powerpc-specific
> sections of the code at all.

I chose to have them in the Power #if case with the .abiversion 2
statement and in the #else for all other architectures. On Power, we
must include .abiversion 2.  I just don't know if on other platforms
.abiversion 2 is a valid statement or not?  So, I chose not to include
it, i.e. don't change anything for other architectures to be sure I
don't break them.  Basically, I took the most conservative approach as
I can't test all the other architectures.

                         Carl