Re: [PATCH v2 4/4] gdb: Suppress "unused" variable warning on Clang

[Tsukasa OI <research_trasio@irq.a4lg.com>]

On 2022/10/13 2:36, Simon Marchi wrote:
> On 9/22/22 04:25, Tsukasa OI via Gdb-patches wrote:
>> Clang generates a warning if there is a variable which is written but not
>> read thereafter.  By the default configuration (with "-Werror"), it causes a
>> build failure (unless "--disable-werror" is specified).
>>
>> Because the cause of this error is in the Bison-generated code
>> ($(srcdir)/gdb/cp-name-parser.y -> $(builddir)/gdb/cp-name-parser.c),
>> this commit suppresses this warning ("-Wunused-but-set-variable") by placing
>> the DIAGNOSTIC_IGNORE_UNUSED_BUT_SET_VARIABLE macro at the end of user
>> prologue of cp-name-parser.y.
> 
> Hi,
> 
> I just sent a patch to fix the same thing as your patch here, but only
> saw your patch after.  However, I took a different, more fine-grained
> approach:
> 
> https://inbox.sourceware.org/gdb-patches/20221012173256.20079-1-simon.marchi@efficios.com/T/#u
> 
> Can you let me know what you think?
> 
> Simon
> 

I always prefer fine-grained approach if we can.  The only reason I
didn't do that on gold is because I didn't know proper place for "(void)
yynerrs".  I cannot approve (as I'm not a maintainer) but I support your
patchset.

Thanks,
Tsukasa