From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123413 invoked by alias); 25 May 2018 17:58:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123404 invoked by uid 89); 25 May 2018 17:58:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 May 2018 17:58:11 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F771C12A3; Fri, 25 May 2018 17:58:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FAB12166BB2; Fri, 25 May 2018 17:58:09 +0000 (UTC) Subject: Re: [RFA 1/4] Use scoped_restore in a couple of interp-related places To: Tom Tromey , gdb-patches@sourceware.org References: <20180430051207.19979-1-tom@tromey.com> <20180430051207.19979-2-tom@tromey.com> From: Pedro Alves Message-ID: Date: Fri, 25 May 2018 18:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180430051207.19979-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00691.txt.bz2 On 04/30/2018 06:12 AM, Tom Tromey wrote: > While looking through the "interp" code I found a couple of spots that > could use scoped_restore. > > ChangeLog > 2018-04-29 Tom Tromey > > * cli/cli-interp.c (safe_execute_command): Ues scoped_restore. Typo: "Ues" -> "Use". > @@ -372,9 +371,6 @@ safe_execute_command (struct ui_out *command_uiout, const char *command, > } > END_CATCH > > - /* Restore the global builder. */ > - current_uiout = saved_uiout; > - I was a little worried about whether exception_print could use current_uiout, but it seems not. So OK. > /* FIXME: cagney/2005-01-13: This shouldn't be needed. Instead the > caller should print the exception. */ > exception_print (gdb_stderr, e); Thanks, Pedro Alves