public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [testsuite, obvious] fix pathname regexp in gdb.base/solib-vanish.exp
Date: Fri, 12 Oct 2018 00:01:00 -0000	[thread overview]
Message-ID: <a7e7229f-c404-e4ec-4946-02f32694a87b@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

When cross-debugging from Windows host, names of source files typically 
print without a directory prefix.  So I was getting a spurious failure like:

Breakpoint 2, bar (y=1) at solib-vanish-lib2.c:21
21        return y + 1;                 /* break here */
(gdb) FAIL: gdb.base/solib-vanish.exp: continue to breakpoint: bar

because the regexp expected a "/" in the filename.  This is easy to fix, 
and in fact in the past I've committed a number of similar patches to 
adjust other testcases expecting a directory prefix as well.  So I've 
committed this one as obvious.

-Sandra

[-- Attachment #2: solib.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]

commit d4330bde6891c74498cea8866ce9992181798861
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Thu Oct 11 16:51:26 2018 -0700

    Fix pathname regexp in gdb.base/solib-vanish.exp.
    
    2018-10-11  Sandra Loosemore  <sandra@codesourcery.com>
    
    	gdb/testsuite/
    	* gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX
    	directory prefix on the filename.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index f907323..ba5fae9 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-11  Sandra Loosemore  <sandra@codesourcery.com>
+
+	* gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX
+	directory prefix on the filename.
+
 2018-10-10  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	* gdb.gdb/unittest.exp: Update expected message informing that
diff --git a/gdb/testsuite/gdb.base/solib-vanish.exp b/gdb/testsuite/gdb.base/solib-vanish.exp
index 928ca4e..a243d3d 100644
--- a/gdb/testsuite/gdb.base/solib-vanish.exp
+++ b/gdb/testsuite/gdb.base/solib-vanish.exp
@@ -98,7 +98,7 @@ gdb_breakpoint "${lib2name}.c:${lib2_lineno}" {allow-pending}
 
 # Verify that both the location and source code are displayed
 gdb_continue_to_breakpoint "bar" \
-    ".*/${lib2name}.c:${lib2_lineno}.*break here.*"
+    ".*${lib2name}.c:${lib2_lineno}.*break here.*"
 
 # This should not segfault
 gdb_test "next" \

                 reply	other threads:[~2018-10-12  0:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7e7229f-c404-e4ec-4946-02f32694a87b@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).