* [testsuite, obvious] fix pathname regexp in gdb.base/solib-vanish.exp
@ 2018-10-12 0:01 Sandra Loosemore
0 siblings, 0 replies; only message in thread
From: Sandra Loosemore @ 2018-10-12 0:01 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
When cross-debugging from Windows host, names of source files typically
print without a directory prefix. So I was getting a spurious failure like:
Breakpoint 2, bar (y=1) at solib-vanish-lib2.c:21
21 return y + 1; /* break here */
(gdb) FAIL: gdb.base/solib-vanish.exp: continue to breakpoint: bar
because the regexp expected a "/" in the filename. This is easy to fix,
and in fact in the past I've committed a number of similar patches to
adjust other testcases expecting a directory prefix as well. So I've
committed this one as obvious.
-Sandra
[-- Attachment #2: solib.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]
commit d4330bde6891c74498cea8866ce9992181798861
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Thu Oct 11 16:51:26 2018 -0700
Fix pathname regexp in gdb.base/solib-vanish.exp.
2018-10-11 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX
directory prefix on the filename.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index f907323..ba5fae9 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-11 Sandra Loosemore <sandra@codesourcery.com>
+
+ * gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX
+ directory prefix on the filename.
+
2018-10-10 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.gdb/unittest.exp: Update expected message informing that
diff --git a/gdb/testsuite/gdb.base/solib-vanish.exp b/gdb/testsuite/gdb.base/solib-vanish.exp
index 928ca4e..a243d3d 100644
--- a/gdb/testsuite/gdb.base/solib-vanish.exp
+++ b/gdb/testsuite/gdb.base/solib-vanish.exp
@@ -98,7 +98,7 @@ gdb_breakpoint "${lib2name}.c:${lib2_lineno}" {allow-pending}
# Verify that both the location and source code are displayed
gdb_continue_to_breakpoint "bar" \
- ".*/${lib2name}.c:${lib2_lineno}.*break here.*"
+ ".*${lib2name}.c:${lib2_lineno}.*break here.*"
# This should not segfault
gdb_test "next" \
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-12 0:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-12 0:01 [testsuite, obvious] fix pathname regexp in gdb.base/solib-vanish.exp Sandra Loosemore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).