public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Stephen Röttger" <sroettger@google.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Update btrace data in maintenance btrace commands
Date: Fri, 28 May 2021 22:13:21 -0400	[thread overview]
Message-ID: <a7ec2e38-e160-f12a-bab3-88b0efb4d5d9@polymtl.ca> (raw)
In-Reply-To: <20210412140128.296921-1-sroettger@google.com>

On 2021-04-12 10:01 a.m., Stephen Röttger via Gdb-patches wrote:
> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
> index b7b3c91f85d..79a6e47a4a6 100644
> --- a/gdb/record-btrace.c
> +++ b/gdb/record-btrace.c
> @@ -269,7 +269,7 @@ require_btrace_thread (void)
>     Throws an error if there is no thread or no trace.  This function never
>     returns NULL.  */
>  
> -static struct btrace_thread_info *
> +struct btrace_thread_info *
>  require_btrace (void)

Since the doc is now in the header, write:

/* See record-btrace.h.  */

here.

I'd LGTM this patch, but I'd like Markus (the btrace specialist) to
give it a look (I think he's away, it will be in a few weeks).

Simon

  parent reply	other threads:[~2021-05-29  2:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 14:01 Stephen Röttger
2021-05-25 13:06 ` [PING] " Stephen Röttger
2021-05-29  2:13 ` Simon Marchi [this message]
2021-06-08 14:05   ` Metzger, Markus T
2021-06-09  9:41     ` Stephen Röttger
2021-08-03  8:49       ` Stephen Röttger
2021-08-03 10:05         ` Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7ec2e38-e160-f12a-bab3-88b0efb4d5d9@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=sroettger@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).