From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E4CD6385800F for ; Sat, 29 May 2021 02:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E4CD6385800F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14T2DMF0025502 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 22:13:27 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14T2DMF0025502 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 289821E813; Fri, 28 May 2021 22:13:22 -0400 (EDT) Subject: Re: [PATCH] Update btrace data in maintenance btrace commands To: =?UTF-8?Q?Stephen_R=c3=b6ttger?= , gdb-patches@sourceware.org References: <20210412140128.296921-1-sroettger@google.com> From: Simon Marchi Message-ID: Date: Fri, 28 May 2021 22:13:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210412140128.296921-1-sroettger@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 29 May 2021 02:13:22 +0000 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 May 2021 02:13:34 -0000 On 2021-04-12 10:01 a.m., Stephen Röttger via Gdb-patches wrote: > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > index b7b3c91f85d..79a6e47a4a6 100644 > --- a/gdb/record-btrace.c > +++ b/gdb/record-btrace.c > @@ -269,7 +269,7 @@ require_btrace_thread (void) > Throws an error if there is no thread or no trace. This function never > returns NULL. */ > > -static struct btrace_thread_info * > +struct btrace_thread_info * > require_btrace (void) Since the doc is now in the header, write: /* See record-btrace.h. */ here. I'd LGTM this patch, but I'd like Markus (the btrace specialist) to give it a look (I think he's away, it will be in a few weeks). Simon