From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0DB823858D3C for ; Mon, 16 May 2022 19:29:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DB823858D3C Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9E8D91E00D; Mon, 16 May 2022 15:29:36 -0400 (EDT) Message-ID: Date: Mon, 16 May 2022 15:29:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 18/18] Introduce catchpoint class Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220502221553.1394743-1-tom@tromey.com> <20220502221553.1394743-19-tom@tromey.com> <8663a834-b227-7c55-c59b-7eea51a5ec1d@simark.ca> <8735hluy0u.fsf@tromey.com> <53da31af-191f-000d-fcd5-266849f64c9a@simark.ca> <87y1z1mj75.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87y1z1mj75.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 19:29:38 -0000 On 2022-05-16 14:22, Tom Tromey wrote: >>> It turns out my test-result comparison script doesn't really note gdb >>> crashes. They probably show up under "missing tests" -- but I've gotten >>> a bit too used to just ignoring that. >>> >>> It would be better if a crash always showed up as a FAIL. > > Simon> In this case, they appear as "UNRESOLVED": > > Simon> UNRESOLVED: gdb.mi/mi-breakpoint-changed.exp: test_insert_delete_modify: catch syscall > > Simon> Does your script consider those as a failure? > > No... does this show up in the gdb.sum file? In theory, yes. > FWIW my script is here: https://github.com/tromey/gdb-testing-scripts > I'm curious what other people use. Maybe I can just switch scripts. Now I use a CI job that filters out a list of known failures. That list is only allowed to shrink, which is why I'm bugging people when I see new failures, it makes my CI job fail :). Simon