public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/python] Add non-variadic versions of PyObject_CallMethod
Date: Wed, 12 Jun 2024 11:09:28 +0200	[thread overview]
Message-ID: <a81bef29-bdb4-4a92-a81f-27c2ec45e3c6@suse.de> (raw)
In-Reply-To: <e0c8d5ee-250c-4923-8923-eab5a2ee79c5@suse.de>

On 6/12/24 00:31, Tom de Vries wrote:
> On 6/11/24 21:55, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> Add non-variadic versions of PyObject_CallMethod that hide these 
>> details, such
>> Tom> that we can use the more intuitive:
>>
>> I expanded on this with some template magic, to make gdb automatically
>> handle all possible overloads.  Let me know what you think.
>>
> 
> This is what I hoped to achieve when I started out rewriting this, but 
> didn't manage.  So, I'm very happy with this solution, thanks for 
> helping out with this.
> 
>> I think this should probably go one step further and make the
>> PyObject_CallMethod macro expand to some error, and then change gdb to
>> use some more obviously gdb-specific name, like gdbpy_call_method --
>> that way people with Python experience won't be confused by the gdb API.
> 
> I took a stab at this, attached below.
> 

Submitted as v3 here ( 
https://sourceware.org/pipermail/gdb-patches/2024-June/209903.html ), 
with $subject slightly changed.

Thanks,
- Tom


      reply	other threads:[~2024-06-12  9:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  8:55 Tom de Vries
2024-06-11 19:55 ` Tom Tromey
2024-06-11 22:31   ` Tom de Vries
2024-06-12  9:09     ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a81bef29-bdb4-4a92-a81f-27c2ec45e3c6@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).