From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 06BD93858D34 for ; Wed, 12 Jun 2024 09:08:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06BD93858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06BD93858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718183332; cv=none; b=GgYWp9RWW3KqM1KVM49QZlBP8uFpc3shLbjpV8TkfJEJ9Kv3bQ7PYRTAbDaYta4MsPj9rZjLxd7lp7r8IvjMpopZ9GCt+S0YtDsY8/JgmklvSI4TQZCuO/7RZsW95tn8Z+OxvUJa7AY9GvzRtmKgB7BCm/U4ChcqFWj0zDY+/44= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718183332; c=relaxed/simple; bh=YIYrNoBeKsE9JaqFbSXljG/H7KZfklZfqm2McogE2Fo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=G/ulgSqqDUhfxPRlsHH3y02uw+KM47HS6DzEs5rZYbuv3f5SiqXk/69nTlsglANn3Teryb1hiVfDl2utDk3GzQ6aELtvuSQEF44ORHHql444ivKkJeKuhOmkHO/ZhnijMVlXWPLStzaLH2eSiZY/P4WOrPD+o1OEhNePHNR2HkA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0BD65BEFC; Wed, 12 Jun 2024 09:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718183329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoneEV5oAfekyfMRLqO2khFoDIhsVF9Vz7+WQiN4pz8=; b=gpAtANQs4ueKdyLZFoHNQEKA+wmCwHOIn1cFhL3OrbtmDHdNdvl8pzx0743v2Bn3fgnuH3 nXqoDhzyfMogwtZxcH4OPGqBKjQAhCIxoH7XqZE8/LxrGm0WcbE8aiHHP3stY1ylUNnYR6 QGVy/cIvoj7QqHcO9MwxYd0R/xnbDTc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718183329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoneEV5oAfekyfMRLqO2khFoDIhsVF9Vz7+WQiN4pz8=; b=pugW2gH88S/gvK+CRBtI1Uv1AG7gdyqyi4zS1guPpTKYYK9SNvGB4OMetdiYTZb3pH9j+i YdmzNSlfk5CU/wAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PfNTyphc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ICyTkT8N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718183328; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoneEV5oAfekyfMRLqO2khFoDIhsVF9Vz7+WQiN4pz8=; b=PfNTyphcUrBHIL612G+NSWoTZQ24lwZBxB7mF89j9FduWS2TYWOoraJwIRweP1JO6YwQ1h h2wsvwWyLBXKa0BYV2uQH2gBSqQjNY50cLfyTjOs5AdPQQwYEpgv0gyVLuA/wB1qv5pvAs 0rjkEJd8/yn0MY1Mld94jTUpy3+sqFk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718183328; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoneEV5oAfekyfMRLqO2khFoDIhsVF9Vz7+WQiN4pz8=; b=ICyTkT8N6lpP5gQZg0uR4kb/OkhnGQIDZawMhfRTDrjaVaW+BubjstFqzdmGSgT40GUJKu /xhARdXGu5FDJxCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D77AE137DF; Wed, 12 Jun 2024 09:08:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id euEuM6BlaWZvaAAAD6G6ig (envelope-from ); Wed, 12 Jun 2024 09:08:48 +0000 Message-ID: Date: Wed, 12 Jun 2024 11:09:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/python] Add non-variadic versions of PyObject_CallMethod From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240611085551.10055-1-tdevries@suse.de> <87wmmvfe45.fsf@tromey.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F0BD65BEFC X-Spam-Score: -4.50 X-Spam-Level: X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[99.98%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/12/24 00:31, Tom de Vries wrote: > On 6/11/24 21:55, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> Add non-variadic versions of PyObject_CallMethod that hide these >> details, such >> Tom> that we can use the more intuitive: >> >> I expanded on this with some template magic, to make gdb automatically >> handle all possible overloads.  Let me know what you think. >> > > This is what I hoped to achieve when I started out rewriting this, but > didn't manage.  So, I'm very happy with this solution, thanks for > helping out with this. > >> I think this should probably go one step further and make the >> PyObject_CallMethod macro expand to some error, and then change gdb to >> use some more obviously gdb-specific name, like gdbpy_call_method -- >> that way people with Python experience won't be confused by the gdb API. > > I took a stab at this, attached below. > Submitted as v3 here ( https://sourceware.org/pipermail/gdb-patches/2024-June/209903.html ), with $subject slightly changed. Thanks, - Tom