From: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>
To: Michael Eager <eager@eagercon.com>,
Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
"Nagaraju Mekala" <nmekala@xilinx.com>
Subject: RE: [Patch, microblaze]: Port of Linux gdbserver
Date: Wed, 10 Sep 2014 15:12:00 -0000 [thread overview]
Message-ID: <a877ed04-f51d-4308-bcb4-b3ee2b496c4e@BL2FFO11FD027.protection.gbl> (raw)
In-Reply-To: <54106294.8030806@eagercon.com>
Sorry for the typo:
>>From another terminal mb-gdb is run and attached to gdbserver process run before using tar remote command and Break point is set and continue.
From another terminal gdb compiled with microblazeel-xilinx-linux-gnu is run and attached to gdbserver process run before using tar remote command and Break point is set and continue.
Thanks & Regards
Ajit
-----Original Message-----
From: Ajit Kumar Agarwal
Sent: Wednesday, September 10, 2014 8:30 PM
To: 'Michael Eager'; Joel Brobecker
Cc: gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: RE: [Patch, microblaze]: Port of Linux gdbserver
>> How has this been tested? Please be specific.
The changes are tested with the Xilinx PetaLinux. The Petalinux is booted up with QEMU and the gdbserver is run as follows.
/bin/gdbserver HOST:1234 application.elf.
From another terminal mb-gdb is run and attached to gdbserver process run before using tar remote command and Break point is set and continue.
All the testing has been done with little-endian binaries. Even the Linux kernel that got booted up are little endian.
Rest my answers are inlined below.
Thanks & Regards
Ajit
-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com]
Sent: Wednesday, September 10, 2014 8:09 PM
To: Ajit Kumar Agarwal; Joel Brobecker
Cc: gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Port of Linux gdbserver
On 09/10/14 07:22, Ajit Kumar Agarwal wrote:
> Please find the updated patch with review feedbacks are incorporated.
>
> [Patch, microblaze]: Port of Linux gdbserver
>
> This patch is the port of Linux gdbserver.
>
> ChangeLog:
> 2014-10-09 Ajit Agarwal <ajitkum@xilinx.com>
>
> * configure.host (microblaze): New.
> (microblaze*-*-linux*): New.
> * configure.tgt (build_gdbserver): New Definition.
> * gdbserver/Makefile.in (microblaze-linux.c): New target.
> * gdbserver/configure.srv (microblaze*-*-linux*): New target.
> * gdbserver/linux-microblaze-low.c: New file.
>
> Signed-off-by:Ajit Agarwal ajitkum@xilinx.com
Please review your patches before you (re)submit them.
+ /* If necessary, recognize more trap instructions here. GDB only uses the
+ one. */
>>One line.
If this exceeds the 80 Cols then also it should be in one Line.
+ else
+ {
+ if (size < sizeof (long))
+ supply_register (regcache, regno, buf + sizeof (long) - size);
+ else
+ supply_register (regcache, regno, buf);
+ }
+}
>>Fix indent.
Could you please explain what indentation is required in the above case.
+static struct usrregs_info microblaze_usrregs_info = {
+ microblaze_num_regs,
+ microblaze_regmap,
+};
>>Fix indent.
I will fix this.
>>How has this been tested? Please be specific.
Answered above.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2014-09-10 15:12 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 10:14 Ajit Kumar Agarwal
2014-09-10 13:31 ` Michael Eager
2014-09-10 13:46 ` Joel Brobecker
2014-09-10 14:23 ` Ajit Kumar Agarwal
2014-09-10 14:39 ` Michael Eager
2014-09-10 14:59 ` Ajit Kumar Agarwal
2014-09-10 15:12 ` Ajit Kumar Agarwal [this message]
2014-09-10 15:27 ` Michael Eager
2014-09-10 15:30 ` Ajit Kumar Agarwal
2014-09-10 15:35 ` Michael Eager
2014-09-10 15:51 ` Ajit Kumar Agarwal
2014-09-10 14:43 ` Joel Brobecker
2014-09-10 15:04 ` Ajit Kumar Agarwal
2014-09-10 15:54 ` Joel Brobecker
2014-09-10 16:10 ` Ajit Kumar Agarwal
2014-09-12 8:01 ` Ajit Kumar Agarwal
2014-09-12 8:39 ` Ajit Kumar Agarwal
2014-09-12 15:38 ` Michael Eager
2014-09-16 6:42 ` Ajit Kumar Agarwal
2014-09-16 12:06 ` Michael Eager
2014-09-17 9:36 ` Ajit Kumar Agarwal
2014-09-17 14:12 ` Michael Eager
2014-09-16 17:04 ` Pedro Alves
2014-09-17 6:16 ` Ajit Kumar Agarwal
2014-09-17 8:15 ` Pedro Alves
2014-09-17 8:20 ` Ajit Kumar Agarwal
2014-09-23 12:49 ` Ajit Kumar Agarwal
2014-09-30 11:43 ` Pedro Alves
2014-09-30 13:27 ` Ajit Kumar Agarwal
2014-09-30 13:37 ` Pedro Alves
2014-09-30 14:21 ` Ajit Kumar Agarwal
2014-10-08 13:52 [Patch] Microblaze: " Ajit Kumar Agarwal
2014-10-09 16:29 ` Michael Eager
2014-10-09 18:54 ` Ajit Kumar Agarwal
2014-10-09 23:42 ` Michael Eager
2014-10-13 16:00 ` Ajit Kumar Agarwal
2014-10-13 17:49 ` Michael Eager
2014-10-14 3:03 ` Ajit Kumar Agarwal
2014-10-14 15:07 ` Michael Eager
2014-10-14 15:33 ` Ajit Kumar Agarwal
2014-10-14 15:42 ` Ajit Kumar Agarwal
2014-10-15 13:27 ` Pedro Alves
2014-10-17 19:22 ` Ajit Kumar Agarwal
2014-12-15 18:02 ` Pedro Alves
2014-12-15 18:13 ` Michael Eager
2014-12-18 8:58 ` Ajit Kumar Agarwal
2014-12-18 16:10 ` Michael Eager
2014-12-18 8:57 ` Ajit Kumar Agarwal
2014-12-18 11:28 ` Pedro Alves
2014-12-18 16:53 ` Ajit Kumar Agarwal
2014-12-18 17:40 ` Pedro Alves
2014-12-19 8:27 ` Ajit Kumar Agarwal
2014-12-19 10:56 ` Pedro Alves
2014-12-19 10:26 ` Ajit Kumar Agarwal
2014-12-19 11:02 ` Pedro Alves
2014-12-19 18:06 ` Ajit Kumar Agarwal
2014-11-26 12:13 ` Ajit Kumar Agarwal
2014-12-15 16:08 ` Ajit Kumar Agarwal
2014-10-08 14:59 Ajit Kumar Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a877ed04-f51d-4308-bcb4-b3ee2b496c4e@BL2FFO11FD027.protection.gbl \
--to=ajit.kumar.agarwal@xilinx.com \
--cc=brobecker@adacore.com \
--cc=eager@eagercon.com \
--cc=gdb-patches@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).