From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 8CDCE385AF9D for ; Tue, 18 Jul 2023 13:43:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CDCE385AF9D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3fbfcc6daa9so53124005e9.3 for ; Tue, 18 Jul 2023 06:43:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689687824; x=1692279824; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rszDJbXODf/AOLOMADQ9KMWHp0lBDQMFYokIGKoJAF4=; b=OfmI4ry/DLTrfBnX13eRngU9vey2aPGJDS0M9nV7vy+QvL0fUBjOUwLPYsioMyWVGQ 3vYtbHSCPetb3px5BH+DrWlRdnL393y7NO145fQI/i83MtIitZ/qP6uayYzoT8YLdV3X aAtnz55nUHyeHoq53UnYF3HYsMAsT9M4z63UJOG2CPCXG1tT9pIHv6ByNPCKgTJj+M7v t5Ggo1owilcpk/avafPECXs57t/UnyoQAb2uag7uOM/4xjcwO2VXT94Wq0gJTaGBAD9m 1+2n56XPbmIgt0Q92Ki/+p7awdX7O6CEMD+uJpnydt0/23dGmdjSVEnRlOAA4wuc33ZY EWKg== X-Gm-Message-State: ABy/qLY92JCjK4wWMFuJLn7eJ9LRSrdMg9uxbEKtp5X8nQkIizfeOqPX CB7+4Shb3QN7z8mdOYAnmTg= X-Google-Smtp-Source: APBJJlEzNFHODQnw2YhmjSc8+/aJe7tkWb6XUf4ioVH5cz7cX4ohzY6f/Js5H9+cDWkeSeSM47x1iA== X-Received: by 2002:a05:600c:452:b0:3fb:a616:76b6 with SMTP id s18-20020a05600c045200b003fba61676b6mr1742403wmb.40.1689687823546; Tue, 18 Jul 2023 06:43:43 -0700 (PDT) Received: from ?IPV6:2001:8a0:f91d:bc00:2d72:1f79:bed1:65bb? ([2001:8a0:f91d:bc00:2d72:1f79:bed1:65bb]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c230c00b003fc01189b0dsm2205240wmo.42.2023.07.18.06.43.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 06:43:42 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 14:43:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] gdb/cli: fixes to newly added "list ." command Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org References: <835af40f-edae-ba48-f121-a1cdd1f1147e@palves.net> <20230718112140.1911522-2-blarsen@redhat.com> From: Pedro Alves In-Reply-To: <20230718112140.1911522-2-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-07-18 12:21, Bruno Larsen via Gdb-patches wrote: > After the series that added this command was pushed, Pedro mentioned > that the news description could easily be misinterpreted, as well as Per the discussion, it's more than misinterpreted, it's factually incorrect. :-) > some code and test improvements that should be made. > > return; > @@ -2805,7 +2805,7 @@ and send its output to SHELL_COMMAND.")); > = add_com ("list", class_files, list_command, _("\ > List specified function or line.\n\ > With no argument, lists ten more lines after or around previous listing.\n\ > -\"list .\" lists ten lines arond where the inferior is stopped.\n\ > +\"list .\" lists ten lines around where the inferior is stopped.\n\ "where the inferior is stopped" should be fixed here too, as it's not what GDB does. > \"list +\" lists the ten lines following a previous ten-line listing.\n\ > \"list -\" lists the ten lines before a previous ten-line listing.\n\ > One argument specifies a line, and ten lines are listed around that line.\n\ > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index cd86da50f46..c9377846bdc 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9155,9 +9155,9 @@ Same as using with no arguments. > Print lines just before the lines last printed. > > @item list . > -Print the lines surrounding the location that is where the inferior > -is stopped. If the inferior is not running, print around the main > -function instead. > +Print the lines surrounding the last solitary line printed as part > +of displaying a fram. If the inferior is not running, print around "fram" -> "frame". > +the main function instead. > @end table