From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 88D2C3858C52 for ; Thu, 28 Sep 2023 18:07:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88D2C3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RxLzh3fhzz3WDY; Thu, 28 Sep 2023 18:07:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RxLzh2sdvz4hGP; Thu, 28 Sep 2023 18:07:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695924448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDKtmQDFjJAbJjL8P290VA6xicgK5Ma+8Hdgtvc3iCM=; b=mJ/smOsOYyLiqmo9JxOht+HcJ90IS1IXPl4pQ4pcvBeS5ImU3DA7xQONUE7KbSFLy6uxBv 0zcnUch474JBy3jAqnw21c/RfzXxfqxmJYLsP6rBP7xw7f5kN3S4hH1xta5HbnMAmQPlmo NMMhskLagcWUo7IOIv4oBPlXYRA2hAIm7Hs2pFYXNRkHkDASy27zSGyy/FvBXOa0wyM7A/ Vm72cH7hxQzbjaZYYh9YHZzR58RGA4+sqEnWDo0UlPyhrBSb5FGxwJJ8MCpJ2WPdGNWYFt IWIAdZrgFCug3bQseZq1n3ACezqX/fn/iaXr9bG4T0hFFqqCjEY3nsqF5/8EQA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695924448; a=rsa-sha256; cv=none; b=hremAsBw698eMp4SwC3dDg0PgLFQNKg427IxZtCEIGj3Kim5BZPG5bdzQhB7F8VW41tu6y H7bcwQU9K95EL8GsEDesW21soQbS65Bsw91HZkxvVwR+irlC3WKYn2hhDqinFyWOEkGZT0 5wjmcVHN6SWv96PavERYuwVH27KMk1DYRcIxF7nEtGkVuMsi+Ag774wiCv5TdKBamoopBJ RaWuDQ72hIkeAbFsueX49abUzAWz5cXoJ1HRjaod/Od09OTNoM1i4ztxSpfdgOLvgwsO5T beWclivNlsynZ2b8KKAjfUFcLC/UJueSGUEnfixvO6pYgQDgLYjhzskN9Zcydg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695924448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDKtmQDFjJAbJjL8P290VA6xicgK5Ma+8Hdgtvc3iCM=; b=AEoMLdkX1ZKzuXOoo0MFGb6CxLqju7OzT7AfGj9cT7an4YY3kMdyas7T85U+q5BVfGFiMI s0/daql7D+8E6SvPV+reh2gydeW/LraEFIZ/9XOIj9OvJAvfw+4jniHe7DkzpLqD89dZeu 8ZhX/OtPXtUWdXpELqu7yBB9c2PQvBjC/wK4neMXb4YPp+grv4iBc8SM3JfV5q6JbPktfw 4YzRI4aY9E6nwiKR+uaTN0IofRljv543Ofkx2ves/lkpzI0YCdcD0lIZg7km4kYl5izzDc Cx/kziPlZ2nwYIjVueTIgrVSnPKSENP5dnwHV9BE6VPf96WHI3cWIDh/v77RrA== Received: from [IPV6:2601:648:8683:39a0:e1b3:8f1c:ed70:9872] (unknown [IPv6:2601:648:8683:39a0:e1b3:8f1c:ed70:9872]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RxLzh03Lbzk8y; Thu, 28 Sep 2023 18:07:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 28 Sep 2023 11:07:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/2] gdb: remove nbsd_{ilp32, lp64}_solib_svr4_fetch_link_map_offsets Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230928174752.389177-1-simon.marchi@efficios.com> <20230928174752.389177-2-simon.marchi@efficios.com> From: John Baldwin In-Reply-To: <20230928174752.389177-2-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote: > They are unused. > > Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf > --- > gdb/netbsd-tdep.c | 15 --------------- > gdb/netbsd-tdep.h | 3 --- > 2 files changed, 18 deletions(-) > > diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c > index ed60200f958b..15a9e2fd7d4e 100644 > --- a/gdb/netbsd-tdep.c > +++ b/gdb/netbsd-tdep.c > @@ -44,21 +44,6 @@ > #define KINFO_VME_FLAG_GROWS_UP 0x00000010 > #define KINFO_VME_FLAG_GROWS_DOWN 0x00000020 > > -/* FIXME: kettenis/20060115: We should really eliminate the next two > - functions completely. */ > - > -struct link_map_offsets * > -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void) > -{ > - return svr4_ilp32_fetch_link_map_offsets (); > -} > - > -struct link_map_offsets * > -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void) > -{ > - return svr4_lp64_fetch_link_map_offsets (); > -} > - > int > nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name) > { > diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h > index ab13e628d582..2adf9a751e3b 100644 > --- a/gdb/netbsd-tdep.h > +++ b/gdb/netbsd-tdep.h > @@ -20,9 +20,6 @@ > #ifndef NBSD_TDEP_H > #define NBSD_TDEP_H > > -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void); > -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void); > - > int nbsd_pc_in_sigtramp (CORE_ADDR, const char *); > > /* NetBSD specific set of ABI-related routines. */ Both patches seem sensible to me, and the NetBSD one in particular looks right. -- John Baldwin