Re: [PATCH v2] gdb/remote: use current_inferior in read_ptid if multi-process not supported

[Pedro Alves <pedro@palves.net>]

On 2022-03-29 09:26, Tankut Baris Aktemur wrote:

> +
> +proc test {target_non_stop} {
> +    global binfile
> +
> +    save_vars { ::GDBFLAGS } {
> +	# Make GDB read files from the local file system, not through the
> +	# remote targets, to speed things up.
> +	set ::GDBFLAGS "${::GDBFLAGS} -ex \"set sysroot\""

We make this conditional everywhere else, except gdb.multi/multi-target.exp.tcl, it seems,
which is where I guess you copied this from.  See the remote host/target checks
added throughout in 8dc558a0724f, like:

+    # If GDB and GDBserver are both running locally, set the sysroot to avoid
+    # reading files via the remote protocol.
+    if { ![is_remote host] && ![is_remote target] } {
+       set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\""
+    }

I think we need to do the same here.

Otherwise LGTM.  Thanks.

Pedro Alves