Re: [PATCH] Remove dead code from windows_nat_target::detach

[Simon Marchi <simark@simark.ca>]

On 2022-07-22 14:56, Tom Tromey via Gdb-patches wrote:
> windows_nat_target::detach has a variable 'detached' that is only set
> after a call to 'error'.  However, this can't happen because 'error'
> throws an exception.
> 
> This patch removes the dead code.
> ---
>  gdb/windows-nat.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
> index 43a2c112db5..9265ed9e632 100644
> --- a/gdb/windows-nat.c
> +++ b/gdb/windows-nat.c
> @@ -1912,22 +1912,16 @@ windows_nat_target::attach (const char *args, int from_tty)
>  void
>  windows_nat_target::detach (inferior *inf, int from_tty)
>  {
> -  int detached = 1;
> -
>    ptid_t ptid = minus_one_ptid;
>    resume (ptid, 0, GDB_SIGNAL_0);
>  
>    if (!DebugActiveProcessStop (windows_process.current_event.dwProcessId))
> -    {
> -      error (_("Can't detach process %u (error %u)"),
> -	     (unsigned) windows_process.current_event.dwProcessId,
> -	     (unsigned) GetLastError ());
> -      detached = 0;
> -    }
> +    error (_("Can't detach process %u (error %u)"),
> +	   (unsigned) windows_process.current_event.dwProcessId,
> +	   (unsigned) GetLastError ());
>    DebugSetProcessKillOnExit (FALSE);
>  
> -  if (detached)
> -    target_announce_detach (from_tty);
> +  target_announce_detach (from_tty);
>  
>    x86_cleanup_dregs ();
>    switch_to_no_thread ();

LGTM.

Simon