From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7D25A3858D35 for ; Fri, 8 Mar 2024 09:07:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D25A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D25A3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709888868; cv=none; b=F0viB4Ge47l39OxfcQuP0C6zLU+lQUZylJOIN566+SdzpnlwnZrDsV4wnK+t8h7gr8ZcPd9pmsjghYKD63PqDcDxb+BQb5zhjIdUA1RwN65xYJGmtqJERJOcqgta3oIUoiSIb6pxyVZgINItOoeWtKNAvU/POMWODDxFZ2cQsrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709888868; c=relaxed/simple; bh=3XbQd0c/MWrOgE9vm6YsGZFugin2rmgYXFmQInSZNyA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fxea8CYf80xXQnlfUq2XBguDeaxra0YgxAvJ+aF8zbEvX7124V0XT8pE3HtcGGU4PFIzmW7BARCdeno2Vxt8drSPoOqH7GCVPNogqkWn5lX30ZaWkuLShIJPR0UhracjXPNsMgxokir8R8ULjgshcN4i2tNMJGsqvnZ/8IXpz9U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709888867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MrdYEljRc1bLQ6dmuFroMhOADxiLC1wdZjGyJ3qCX2A=; b=QLiUDKWmwnpOF7eZdFZ64ZiUEWmuSYYRKW2Vx1yal403uvvr6WgMD2BS3DPkSHa6R5w9Cm 5e8YNi9IKX1AYr4ZzxtUOuuDcHITTzYRiRTXbINDEBYJOZPMDBFIWM6NEBdKgDMtA9cjRG +Idc0n1XJWtodvIkcRQgRoyU/1lZ8T8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-PLHdBlQCMKaLqkOzx3VHkA-1; Fri, 08 Mar 2024 04:07:45 -0500 X-MC-Unique: PLHdBlQCMKaLqkOzx3VHkA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33e6fd52037so600635f8f.0 for ; Fri, 08 Mar 2024 01:07:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709888864; x=1710493664; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MrdYEljRc1bLQ6dmuFroMhOADxiLC1wdZjGyJ3qCX2A=; b=dAYqf5I8D1D6I428XYdaoMzHwnrkUf6C6uS+TelUriwG1iTJAU/rjOxJxjIOmm9qeL e+oWMJJnjh9PUef3nLeBNDBN5LLJB+kbTjQnXlTKFIxEBO0yi0MnUZ23hx7xnOpDFLvm dHHid7aHKFZpgVman9NASpohKP+BUaRO2i6hZOlZ9rtDMqRspFPUin1Lyg9y0ibF4wct Wxy0NoE7F3f1zJ+bnUPe3Btj8unZfJm8iVPP2VWTTrWMLooNWH8LQFEr6ZNUwB8Ylz8j p9xUIcSspAg/c9aOcB2BBxSkYRUEF49bg14hizH+qZ9AHEySjDrvl6V76dcQctaDT7nr 1hoQ== X-Forwarded-Encrypted: i=1; AJvYcCU3qrKmwGCn/GnM5aQvuDxc/TCDtXsKrwn6QzNWHSnznBJ9Mpq4PJB46+pqa3J/4ZY02GFqoTENQmaE0PRcmVkGXRGpI72W5XWrjg== X-Gm-Message-State: AOJu0YxXXM3cX1Dj+jQSxiSIk2kd7FPtCJXeuePO8kgUy2WcHxtlxlbV jTTBNAzpCIqn1VLhL7luZ0BYd8rgCBB3yrncD2BZorjf+yQ6pwMkuBoxNrXRnUnOGmhOaCKSgaE tNSorTFtFr08n+1QCmSsqu2MO8VUa2Fhrh+IJ2/dteOeumpIoMjSq7nN5G3E= X-Received: by 2002:adf:e910:0:b0:33e:7865:e05d with SMTP id f16-20020adfe910000000b0033e7865e05dmr568757wrm.35.1709888864389; Fri, 08 Mar 2024 01:07:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGryNVAsazE4K3g0HzgRn+/1YGYStwgl+cfAfwXGcmfBX5f+cwQF4QJsuflitJsDBRuqdBtaw== X-Received: by 2002:adf:e910:0:b0:33e:7865:e05d with SMTP id f16-20020adfe910000000b0033e7865e05dmr568739wrm.35.1709888863940; Fri, 08 Mar 2024 01:07:43 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id ay30-20020a5d6f1e000000b0033e239040d8sm19224663wrb.84.2024.03.08.01.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 01:07:43 -0800 (PST) Message-ID: Date: Fri, 8 Mar 2024 10:07:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, btrace: fix error diagnostics To: Markus Metzger , gdb-patches@sourceware.org References: <20240307150110.3348612-1-markus.t.metzger@intel.com> From: Guinevere Larsen In-Reply-To: <20240307150110.3348612-1-markus.t.metzger@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/03/2024 16:01, Markus Metzger wrote: > When we improved error messages in > > cd393cec3ab gdb, btrace: improve error messages > > we cleared the original errno. When the error reason can not be explained > in a more detailed error message, and we fall back to the default error > message, it now gives Success as error. > > Restore the original errno to fix that. Hi! LGTM, Reviewed-By: Guinevere Larsen -- Cheers, Guinevere Larsen She/Her/Hers > --- > gdb/nat/linux-btrace.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c > index 50de2415589..f8352b62b8b 100644 > --- a/gdb/nat/linux-btrace.c > +++ b/gdb/nat/linux-btrace.c > @@ -422,7 +422,8 @@ cpu_supports_bts (void) > static void > diagnose_perf_event_open_fail () > { > - switch (errno) > + int orig_errno = errno; > + switch (orig_errno) > { > case EPERM: > case EACCES: > @@ -443,7 +444,7 @@ diagnose_perf_event_open_fail () > break; > } > > - error (_("Failed to start recording: %s"), safe_strerror (errno)); > + error (_("Failed to start recording: %s"), safe_strerror (orig_errno)); > } > > /* Get the linux version of a btrace_target_info. */