From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id A89953858C83 for ; Fri, 14 Oct 2022 13:32:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A89953858C83 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EAotaZ019789; Fri, 14 Oct 2022 15:32:25 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3k5v4n96gw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 15:32:25 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D3C4710003D; Fri, 14 Oct 2022 15:32:19 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id CA51F22F7AF; Fri, 14 Oct 2022 15:32:19 +0200 (CEST) Received: from [10.252.14.91] (10.75.127.117) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 15:32:16 +0200 Message-ID: Date: Fri, 14 Oct 2022 15:32:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v4] gdb/arm: Stop unwinding on error, but do not assert Content-Language: en-US To: Luis Machado , Pedro Alves , References: <20221013181135.688646-1-torbjorn.svensson@foss.st.com> <6d3e2120-15bf-25e6-8914-8ec5b6e67976@palves.net> From: Torbjorn SVENSSON In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.117] X-ClientProxiedBy: GPXDAG2NODE4.st.com (10.75.127.68) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_08,2022-10-14_01,2022-06-22_01 X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 13:32:37 -0000 On 2022-10-14 14:03, Luis Machado wrote: > On 10/14/22 12:45, Pedro Alves wrote: >> On 2022-10-13 7:11 p.m., Torbjörn SVENSSON wrote: >>> When it's impossible to read the FPCCR and XPSR, the unwinding is >>> unpredictable as the it's not possible to determine the correct >>> frame size or padding. >>> The only sane thing to do in this condition is to stop the unwinding. >>> >>> Example session wihtout this patch: >> >> wihtout -> without >> >> Thank you, this version LGTM.  This way, there's a better chance gdb can >> distinguish different "outermost" frames, e.g., for watchpoints on >> local vars, >> or for stepping from a "broken" frame, to another "broken" frame. >> >> I'll defer final approval to Luis. >> >> Reviewed-by: Pedro Alves > > LGTM. Pushed.