From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id CA7FB385ED4B
 for <gdb-patches@sourceware.org>; Fri,  4 Dec 2020 21:14:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CA7FB385ED4B
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0B4LEPW4020294
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Fri, 4 Dec 2020 16:14:30 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0B4LEPW4020294
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 254831E590;
 Fri,  4 Dec 2020 16:14:25 -0500 (EST)
Subject: Re: [PATCH v2 13/14] gdb: make displaced stepping implementation
 capable of managing multiple buffers
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
References: <20201202154805.1484317-1-simon.marchi@polymtl.ca>
 <20201202154805.1484317-14-simon.marchi@polymtl.ca>
 <c4ca9ea3-3ee6-cd7b-3ad7-c8b74b2e16bc@palves.net>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <aa04cd36-3b12-b24a-4153-c4bdd6952b5c@polymtl.ca>
Date: Fri, 4 Dec 2020 16:14:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <c4ca9ea3-3ee6-cd7b-3ad7-c8b74b2e16bc@palves.net>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 4 Dec 2020 21:14:25 +0000
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Dec 2020 21:14:34 -0000

On 2020-12-03 8:51 p.m., Pedro Alves wrote:
> On 12/2/20 3:48 PM, Simon Marchi via Gdb-patches wrote:
> 
>>    /* Save this, now that we know everything went fine.  */
>> -  m_copy_insn_closure = std::move (copy_insn_closure);
>> +  buffer->copy_insn_closure = std::move (copy_insn_closure);
>>  
>> -  /* Tell GDB not to try preparing a displaced step again for this inferior.  */
>> +  /* Tell GDB not to try preparing a displaced step again for this inferior if
>> +     all buffers are taken.  */
> 
> Another spot where "Tell GDB" -> "Tell infrun" would make sense, IMO.

Fixed it in patch 11 where it was first added.

Simon