Re: [PATCH v2 00/13] Make frame_info_ptr automatic

[Simon Marchi <simon.marchi@polymtl.ca>]

On 12/20/22 11:57, Bruno Larsen wrote:
> On 14/12/2022 04:34, Simon Marchi via Gdb-patches wrote:
>> This is v2 of:
>>
>>    https://inbox.sourceware.org/gdb-patches/20221202180052.212745-1-simon.marchi@polymtl.ca/
>>
>> The first main change is that I dropped the patch removing the user of
>> frame_info_ptr at many places, following Tom's comment.  If we end up
>> trying to reinflate a frame at a moment where it's not possible (because
>> the frame's id is being computed), we'll hit an assert in
>> frame_info_ptr.  This is fine, because it indicates some logic problem
>> in GDB.
>>
>> The second main change, found after doing the first one, is to fix a bug
>> with the user-created frame reinflation.  In v1, if we had two
>> frame_info_ptr wrapping the same user-created frame_info object, they
>> would each create their own frame_info instance on reinflation.  And
>> that confused GDB down the line.  There are a few new patches to deal
>> with that, by adding user-created frames to the frame stash, so they can
>> be found by frame_info_ptr when reinflating.
>>
>> At the end of the series, frame_info_ptr::frame_info_ptr (at the end of
>> the series) accesses some frame_info internals (the frame's id, without
>> calling get_frame_id), so I decided to move frame_info_ptr to
>> frame.{c,h} (patch 6).  I think that makes sense anyway, as the logic in
>> the implementation of frame_info_ptr is tightly coupled to the rest of
>> the frame stuff.  However, to do so, we need to break some inclusion
>> cycles.  This is done in the few patches before.  Patches 1 and 2 are
>> not strictly necessary, but fix oddities I found along the way.
>>
>> Regression-tested on Ubuntu 22.04 x86-64.
> 
> This series doesn't add any regressions and is where I wanted to take frame_info_ptr all along. I have only one nit with patch 6 (sent as a direct reply), but other than that:
> 
> Reviewed-By: Bruno Larsen <blarsen@redhat.com>
> 

Thanks for reviewing, I will add your RB to all patches.

Simon