From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D25773858D1E for ; Tue, 3 Jan 2023 19:00:34 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 303J0ScL007186 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Jan 2023 14:00:33 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 303J0ScL007186 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1672772433; bh=a/RFvEZVOEvBzUi/hUhDUGtresJi6kg8QXxtkTWoUqE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=H5lpbup2e2YsR8qby2nAiKe5SmOzdzLoBSpBLRQZfLM9b9Pf/QVDUbPJYmbJXQG6i elO1VZaY/Cf80eeNsxdl4CE36ZvM6OWh3V772VvgdppqR+TS9xZjbTq4Ew2EjNH8Cx Wyn7NyVUrh8AyP55ZgLz4Jq/a/kk8zsylQ/kMU9E= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4AA931E112; Tue, 3 Jan 2023 14:00:28 -0500 (EST) Message-ID: Date: Tue, 3 Jan 2023 14:00:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 00/13] Make frame_info_ptr automatic Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org References: <20221214033441.499512-1-simon.marchi@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 3 Jan 2023 19:00:28 +0000 X-Spam-Status: No, score=-3033.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/22 11:57, Bruno Larsen wrote: > On 14/12/2022 04:34, Simon Marchi via Gdb-patches wrote: >> This is v2 of: >> >> https://inbox.sourceware.org/gdb-patches/20221202180052.212745-1-simon.marchi@polymtl.ca/ >> >> The first main change is that I dropped the patch removing the user of >> frame_info_ptr at many places, following Tom's comment. If we end up >> trying to reinflate a frame at a moment where it's not possible (because >> the frame's id is being computed), we'll hit an assert in >> frame_info_ptr. This is fine, because it indicates some logic problem >> in GDB. >> >> The second main change, found after doing the first one, is to fix a bug >> with the user-created frame reinflation. In v1, if we had two >> frame_info_ptr wrapping the same user-created frame_info object, they >> would each create their own frame_info instance on reinflation. And >> that confused GDB down the line. There are a few new patches to deal >> with that, by adding user-created frames to the frame stash, so they can >> be found by frame_info_ptr when reinflating. >> >> At the end of the series, frame_info_ptr::frame_info_ptr (at the end of >> the series) accesses some frame_info internals (the frame's id, without >> calling get_frame_id), so I decided to move frame_info_ptr to >> frame.{c,h} (patch 6). I think that makes sense anyway, as the logic in >> the implementation of frame_info_ptr is tightly coupled to the rest of >> the frame stuff. However, to do so, we need to break some inclusion >> cycles. This is done in the few patches before. Patches 1 and 2 are >> not strictly necessary, but fix oddities I found along the way. >> >> Regression-tested on Ubuntu 22.04 x86-64. > > This series doesn't add any regressions and is where I wanted to take frame_info_ptr all along. I have only one nit with patch 6 (sent as a direct reply), but other than that: > > Reviewed-By: Bruno Larsen > Thanks for reviewing, I will add your RB to all patches. Simon