From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <patrick@monnerat.net>
Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226])
 by sourceware.org (Postfix) with ESMTPS id 7B01F3853838
 for <gdb-patches@sourceware.org>; Sun, 15 Aug 2021 00:30:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B01F3853838
Received: from patrick.monnerat ([192.168.0.128])
 by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 17F0U2Hv012976
 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 15 Aug 2021 02:30:07 +0200
DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 17F0U2Hv012976
Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20210813222411.3076-1-patrick@monnerat.net>
 <3002b4db-52a4-b7a5-ca1a-49398ba439ed@polymtl.ca>
From: Patrick Monnerat <patrick@monnerat.net>
Message-ID: <aa262ca5-ddbc-80a9-e564-40e3e5093bcb@monnerat.net>
Date: Sun, 15 Aug 2021 02:30:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <3002b4db-52a4-b7a5-ca1a-49398ba439ed@polymtl.ca>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, NICE_REPLY_A,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Aug 2021 00:30:32 -0000


On 8/14/21 6:05 AM, Simon Marchi wrote:
> I looked at the change a bit more in depth, in particular at the various
> observers of breakpoint_modified.  One of them is MI, who prints the
> =breakpoint-modified notification.

Good catch !

> if I run a program with a breakpoint with "enable
> count 1 1", the notification I get without your patch is:
>
>    =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="n",...
>                                                                                ^
> And with the patch:
>
>    =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="y",
>                                                                                ^

You probably mean the other way round...


Next patch post will contain tests according to your advices.

Many thanks for your hints and your work on this.

Patrick