Re: [PATCH 1/5] Remove gdb/testsuite/configure

[Tom de Vries <tdevries@suse.de>]

On 6/1/21 3:59 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
>>> -EXTRA_RULES = @EXTRA_RULES@
>>> +ifeq ($(build_canonical),$(host_canonical))
>>> +ifeq ($(host_canonical),$(target_canonical))
>>> +ifneq (,$(findstring gnu,$(host_canonical)))
>>> +EXTRA_RULES = read1
>>> +endif
>>> +endif
>>> +endif
> 
> Simon> Could the read1 artifacts be built as a dependency of the "make
> Simon> check-read1" target (so, on-demand)?  Either way is fine with me, but it
> Simon> would just be a little bit less complexity.
> 
> Sure.  If anybody relies on being able to do this without using 'make',
> there's already a 'read1' convenience target that can be used.
> 
> I'm going to check this in with this change.
> 

So, before this commit we had:
...
$ ( cd build/gdb/testsuite/; make check READ1=1
RUNTESTFLAGS=gdb.base/info-types-c.exp )
gcc -o read1.so
/home/vries/gdb_versions/devel/src/gdb/testsuite/lib/read1.c -Wall -g
-shared -fPIC
Making expect-read1
Nothing to be done for all...
Making a new config file...
make check-single
...

And after:
...
$ ( cd build/gdb/testsuite/; make check READ1=1
RUNTESTFLAGS=gdb.base/info-types-c.exp )
Nothing to be done for all...
Making a new config file...
make check-single
make[1]: Entering directory
'/home/vries/gdb_versions/devel/build/gdb/testsuite'
rootme=`pwd`; export rootme;
srcdir=/home/vries/gdb_versions/devel/src/gdb/testsuite ; export srcdir
; EXPECT=`if [ "${READ1}" != "" ] ; then echo ${rootme}/expect-read1;
elif [ -f ${rootme}/../../expect/expect ] ; then echo
${rootme}/../../expect/expect ; else echo expect ; fi` ; export EXPECT ;
EXEEXT= ; export EXEEXT ;
LD_LIBRARY_PATH=$rootme/../../expect:$rootme/../../libstdc++:$rootme/../../tk/unix:$rootme/../../tcl/unix:$rootme/../../bfd:$rootme/../../opcodes:$LD_LIBRARY_PATH;
export LD_LIBRARY_PATH; if [ -f ${rootme}/../../expect/expect ] ; then
TCL_LIBRARY=${srcdir}/../../tcl/library ; export TCL_LIBRARY ; fi ; ` if
[ -f ${srcdir}/../../dejagnu/runtest ]; then echo
${srcdir}/../../dejagnu/runtest; else if [ "x86_64-pc-linux-gnu" =
"x86_64-pc-linux-gnu" ]; then echo runtest; else t='s,y,y,'; echo
runtest | sed -e $t; fi; fi` --status gdb.base/info-types-c.exp
ERROR: unable to find expect in the PATH
make[1]: *** [Makefile:206: check-single] Error 1
make[1]: Leaving directory
'/home/vries/gdb_versions/devel/build/gdb/testsuite'
make: *** [Makefile:159: check] Error 2
...

Then after running check-read1, this works again.

Personally I'm fine with no longer supporting this.  But perhaps others
use READ1=1 in combination with some nonstandard make target?  I'm not sure.

Anyway, if we decide to leave things as they are now, we should document
this in gdb/testsuite/README:
...
 Examples:

         make -j10 check-read1 TESTS="*/paginate-*.exp"
-        make -j10 check READ1="1"
...

Thanks,
- Tom