From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id DCE3B386100B for ; Sat, 5 Jun 2021 09:51:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCE3B386100B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E31191FD2F; Sat, 5 Jun 2021 09:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622886665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8IahwTR4l30dTg5x40lAa/ZseAT3xtsqCiofHL3cUI=; b=pDS5V15jjYSdsq88iLLKqlBSSxS20nC2hJkt2NbbjtGln2VdNUbtMFqO/wQWAsUuTUXiez 35UbKgP1wOLgz4KjeIRWSeoAzzm6Ed3SV+5RWJ/CUenxQMPTKZIwM66t6AsJL7tzQ8YOJ/ iTZheoarmEfLLx8tnZiRYq/QGGGEcGc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622886665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8IahwTR4l30dTg5x40lAa/ZseAT3xtsqCiofHL3cUI=; b=iqpNst3yoPjYppD7FQ84LnOdxXweEIw7IFrTeunIrqlsIA5G0jBDBsXUttE7tfD/MeC0vi wi4HxlwSI4Lj/MDQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id BA13C118DD; Sat, 5 Jun 2021 09:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622886665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8IahwTR4l30dTg5x40lAa/ZseAT3xtsqCiofHL3cUI=; b=pDS5V15jjYSdsq88iLLKqlBSSxS20nC2hJkt2NbbjtGln2VdNUbtMFqO/wQWAsUuTUXiez 35UbKgP1wOLgz4KjeIRWSeoAzzm6Ed3SV+5RWJ/CUenxQMPTKZIwM66t6AsJL7tzQ8YOJ/ iTZheoarmEfLLx8tnZiRYq/QGGGEcGc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622886665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8IahwTR4l30dTg5x40lAa/ZseAT3xtsqCiofHL3cUI=; b=iqpNst3yoPjYppD7FQ84LnOdxXweEIw7IFrTeunIrqlsIA5G0jBDBsXUttE7tfD/MeC0vi wi4HxlwSI4Lj/MDQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id bbRbLAlJu2BoegAALh3uQQ (envelope-from ); Sat, 05 Jun 2021 09:51:05 +0000 Subject: Re: [PATCH 1/5] Remove gdb/testsuite/configure To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20210528192743.508390-1-tromey@adacore.com> <20210528192743.508390-2-tromey@adacore.com> <874kehsn2y.fsf@tromey.com> From: Tom de Vries Message-ID: Date: Sat, 5 Jun 2021 11:51:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <874kehsn2y.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2021 09:51:17 -0000 On 6/1/21 3:59 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> -EXTRA_RULES = @EXTRA_RULES@ >>> +ifeq ($(build_canonical),$(host_canonical)) >>> +ifeq ($(host_canonical),$(target_canonical)) >>> +ifneq (,$(findstring gnu,$(host_canonical))) >>> +EXTRA_RULES = read1 >>> +endif >>> +endif >>> +endif > > Simon> Could the read1 artifacts be built as a dependency of the "make > Simon> check-read1" target (so, on-demand)? Either way is fine with me, but it > Simon> would just be a little bit less complexity. > > Sure. If anybody relies on being able to do this without using 'make', > there's already a 'read1' convenience target that can be used. > > I'm going to check this in with this change. > So, before this commit we had: ... $ ( cd build/gdb/testsuite/; make check READ1=1 RUNTESTFLAGS=gdb.base/info-types-c.exp ) gcc -o read1.so /home/vries/gdb_versions/devel/src/gdb/testsuite/lib/read1.c -Wall -g -shared -fPIC Making expect-read1 Nothing to be done for all... Making a new config file... make check-single ... And after: ... $ ( cd build/gdb/testsuite/; make check READ1=1 RUNTESTFLAGS=gdb.base/info-types-c.exp ) Nothing to be done for all... Making a new config file... make check-single make[1]: Entering directory '/home/vries/gdb_versions/devel/build/gdb/testsuite' rootme=`pwd`; export rootme; srcdir=/home/vries/gdb_versions/devel/src/gdb/testsuite ; export srcdir ; EXPECT=`if [ "${READ1}" != "" ] ; then echo ${rootme}/expect-read1; elif [ -f ${rootme}/../../expect/expect ] ; then echo ${rootme}/../../expect/expect ; else echo expect ; fi` ; export EXPECT ; EXEEXT= ; export EXEEXT ; LD_LIBRARY_PATH=$rootme/../../expect:$rootme/../../libstdc++:$rootme/../../tk/unix:$rootme/../../tcl/unix:$rootme/../../bfd:$rootme/../../opcodes:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; if [ -f ${rootme}/../../expect/expect ] ; then TCL_LIBRARY=${srcdir}/../../tcl/library ; export TCL_LIBRARY ; fi ; ` if [ -f ${srcdir}/../../dejagnu/runtest ]; then echo ${srcdir}/../../dejagnu/runtest; else if [ "x86_64-pc-linux-gnu" = "x86_64-pc-linux-gnu" ]; then echo runtest; else t='s,y,y,'; echo runtest | sed -e $t; fi; fi` --status gdb.base/info-types-c.exp ERROR: unable to find expect in the PATH make[1]: *** [Makefile:206: check-single] Error 1 make[1]: Leaving directory '/home/vries/gdb_versions/devel/build/gdb/testsuite' make: *** [Makefile:159: check] Error 2 ... Then after running check-read1, this works again. Personally I'm fine with no longer supporting this. But perhaps others use READ1=1 in combination with some nonstandard make target? I'm not sure. Anyway, if we decide to leave things as they are now, we should document this in gdb/testsuite/README: ... Examples: make -j10 check-read1 TESTS="*/paginate-*.exp" - make -j10 check READ1="1" ... Thanks, - Tom