From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-150008-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14792 invoked by alias); 22 Aug 2018 18:19:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14760 invoked by uid 89); 22 Aug 2018 18:19:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Aug 2018 18:19:26 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7MIJKFb008946	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Wed, 22 Aug 2018 14:19:25 -0400
Received: by simark.ca (Postfix, from userid 112)	id 6599E1EB3B; Wed, 22 Aug 2018 14:19:20 -0400 (EDT)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id 1EAB21E76F;	Wed, 22 Aug 2018 14:19:19 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 22 Aug 2018 18:19:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Make read_program_header return a gdb::byte_vector
In-Reply-To: <20180822104534.17865bb5@pinnacle.lan>
References: <20180820012947.10928-1-simon.marchi@polymtl.ca> <20180822104534.17865bb5@pinnacle.lan>
Message-ID: <aa4ca6f51f57d949e66c314430373740@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.6
X-IsSubscribed: yes
X-SW-Source: 2018-08/txt/msg00557.txt.bz2

On 2018-08-22 13:45, Kevin Buettner wrote:
> On Sun, 19 Aug 2018 21:29:46 -0400
> Simon Marchi <simon.marchi@polymtl.ca> wrote:
> 
>> +   optional on failure.  If successful and P_ATCH_SIZE is non-NULL, 
>> the target
> 
> I noticed this typo: P_ATCH_SIZE should be P_ARCH_SIZE.
> 
> Otherwise, LGTM.

Thanks, I pushed the series with that fixed.

Simon