From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 8A3413858D39 for ; Wed, 20 Sep 2023 16:42:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A3413858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-400a087b0bfso57035e9.2 for ; Wed, 20 Sep 2023 09:42:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695228170; x=1695832970; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=854AEnItG0GUlQHlmojgSjGJBn0S9NEeJ3RBJOCw93E=; b=ovGxNiSJYxaPaOTq9KFPjDMLTtBSlcpDNYuHPl7dK2fmI4g/8SxmxLaw8uLtBR0FRX 3rK/Yx5VVpZFyoUZLgD93qQRkAwH9fM7pKoxCkB+l+q/nw9JyMaNPYKV6gTSrplrEffL XNss1h7ae1bMPkBtOyM+75qCd6ss8S4KrZ4qKQCGneXCRpKAF9MZDR2Zgly9wFUqe8cZ /qNc/8CpxNnBwxgnr+aNM8xtkDJC5jTXnIO6CywBABaMU4WBYVEgJ+hCJ5VKGZ1oLuwO qAajBZ+zm1Ue2m3GmVFAX75bJOetl87e9ysBiylLLWfwzFNnTfaPCu0YA9GuwLUL2Xd8 bKzA== X-Gm-Message-State: AOJu0YwCktT2iPCGvpCMdeZBYtZd1n69o3tdj1IMpuF68Xd+laHAnIww t21V+J9N7WD6kK8YViq0kMAcCEabuWvKfg== X-Google-Smtp-Source: AGHT+IGVruJN5D/NgoswJsnduSOyUzQX4tKktTwO8V3KcrFk+43rBHaYpLHDUmY5lXR/n6SaHeSDNw== X-Received: by 2002:a05:600c:24e:b0:401:8225:14ee with SMTP id 14-20020a05600c024e00b00401822514eemr2888911wmj.41.1695228170021; Wed, 20 Sep 2023 09:42:50 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:f66d:9e3b:9c38:4aec? ([2001:8a0:f939:d200:f66d:9e3b:9c38:4aec]) by smtp.gmail.com with ESMTPSA id l20-20020a1ced14000000b003fee6e170f9sm2394537wmh.45.2023.09.20.09.42.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 09:42:49 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 17:42:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/2] gdb: keep record of thread numbers for reverse execution targets Content-Language: en-US To: Tom Tromey , Magne Hov via Gdb-patches References: <20230629083651.3145268-1-mhov@undo.io> <20230707162451.3605544-1-mhov@undo.io> <20230707162451.3605544-2-mhov@undo.io> <871qeu86nm.fsf@tromey.com> From: Pedro Alves In-Reply-To: <871qeu86nm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-09-19 17:33, Tom Tromey wrote: >>>>>> "Magne" == Magne Hov via Gdb-patches writes: > > Magne> Targets that support reverse execution may report threads that have > Magne> previously been seen to exit. Currently, GDB assigns a new thread > Magne> number every time it sees the same thread (re)appearing, but this is > Magne> problematic because it makes the output of `info threads` inconsistent, > Magne> and because thread-specific breakpoints depend on stable thread-numbers > Magne> in order to stop on the right thread. > > Thank you for the patch. > > Magne> + std::unordered_map, hash_ptid> ptid_thread_num_map; > > You'll have to update this for the hash_ptid -> std::hash > change. However, that's trivial. I think I have some concerns. Could you hold off a bit? Sorry I've not managed to stay on top of patch as I'd wish I would.