From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 01B933858D35 for ; Mon, 22 Apr 2024 17:18:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01B933858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01B933858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713806281; cv=pass; b=WEx7HdLX/lM7S7EFkbFAOOFVA3Xx7/iGBCDNVT1kSg/k5LWk4zi4MrJBKkwE3pxaZUXrcZDi6p97l8wkJ4FJLO1uCIIvHRp+XC9UuVvOuWNp+ZQ7ThZUqDQGtZ1/UCVXxDhzUwC9MYHdo8x1bcYNhmSQKOm4gcPt3EAppitfUrI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713806281; c=relaxed/simple; bh=z1ChYAyYwlBdsGJdYkJPXMlu5OInTQsrE2s5bio9r+g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=msGYpvWNHCS59DflWkQJq7rd55vy4PBFwqDuRp9ZILehqnp6gZMPa7uFyLksW677koFbGfIrAifKIVFILOa3vIkIH1gH4SK/HengQ7OLEU5Rrbf3+w/+98Jht9WT0oxhv6Vo43FYVOniohqwcSQWAzaQzurCih9IkWl4n2PmWrc= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4VNX5362DNz3qFg; Mon, 22 Apr 2024 17:17:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VNX534BX0z4NbD; Mon, 22 Apr 2024 17:17:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713806279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D1A2+DUJLvwaUsvkx6cvH0oNsN2JC9AnJPWBANzZV1Q=; b=CwcOyX4usgiAmUoiBplLypM8Hd6tMVefx8IYRKnvwc+KdOhu+g3aj+kvbPHs5/UTDgFBoS Rew3QhUv2JQHENztnr7TCwf0Xw5fpE9wOV/oY0FqGGSgR9iMZtt6Pb/56ZJnjWYQtwlaDw okXy+RtQbe9a/0vaKolALMMFsdU/DsPca4Q9xYCgP8BzihG7OmELm13etq91wZK4pbB6fp HBegNBW0Dgi4rXxbOw9nv+OmcQj/o32E5FFUTu8mqVUF0yn6nS4DPwmb3RgwtA/jgh4v5f 7YlN3v0Lwz+cAf+gRjHHLhY6se3p23AEk42tPwJsajpf6PADhaT9j5lLGcGknQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713806279; a=rsa-sha256; cv=none; b=tcr6NEh3fXMTk4vLs1nQXE+5KphqVeoRPdC142WFhuCo0/cwQSHxH8VlOl1xamOE0aXcrV 8Iso67LIRgBFhqIhTqU1EKgb7cgmhS6Z8kydqVwfopvpG0WqGzK1S4rUwIYzgedVapmow2 SbRjo9m4IT968GQQsujtg8+oG7zqq0OCLU5A9mzwTpe1Q2ylci9DnMxmkga1re6uPJaOrD ouc8SakiJRpwRcXR6JeS4avb4IKs5oNoRiiqygiVweiyGLARBUymVnyLth97m2+0HpctIB QHrpB5u4kOkbO4oUkZboDEfSKrfLsMfR7guhdgnMOpt500FZCxbyVR/zDi39uw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713806279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D1A2+DUJLvwaUsvkx6cvH0oNsN2JC9AnJPWBANzZV1Q=; b=Xm+zWbyCtUILu41yNqXpNz5dVALNxKNzvElesh0j/nnJ97Zvt1OAJ82wIQOjrefaJ6GIOT L0Fh0lzLqoAS5cBIMvDCDbE1i4dzwdqCw5RAJL9A2gZHpEhr3vDs/viWaW2XtY5EQkWk0X lDecKqiVdP6pNc146yQfs8XikZQpMKS+5x+wa0rW/L+I/OZiRxlEquthvS2B0roZEDbFN+ 7t/3lu6grN6M1GlN8+22AAkO1112hw1DDPiM0bS9jH9QsP0ZSTob+69NScV3aL1PgX5JwE Q++O8LEtC4Ncru46Tj4LqGsMW0wMt9J6Ym1qlK3rlR7SbdBoojDSHwS52Gmrjg== Received: from [IPV6:2601:644:937f:4c50:48e:b274:3ff6:85b] (unknown [IPv6:2601:644:937f:4c50:48e:b274:3ff6:85b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VNX531jnKz1Pkv; Mon, 22 Apr 2024 17:17:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 22 Apr 2024 10:17:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/10] Change storage of demangle_component Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240421-canon-fixes-v1-0-4dc4791d270d@tromey.com> <20240421-canon-fixes-v1-4-4dc4791d270d@tromey.com> From: John Baldwin In-Reply-To: <20240421-canon-fixes-v1-4-4dc4791d270d@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/21/24 10:00 AM, Tom Tromey wrote: > This changes demangle_component objects to be stored on the obstack > that is part of demangle_info. It also arranges for a demangle_info > object to be kept alive by cp_merge_demangle_parse_infos. This way, > other data on the obstack can be kept while an "outer" demangle_info > needs it. The mechanical changes to switch to using better memory management look ok to me. I did not do a detailed review of the objects' relationships to understand the "outer" comment in the log. (Not quite sure where on the line this falls for Acked-By vs Approved-By) Acked-By: John Baldwin -- John Baldwin