From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12812 invoked by alias); 6 Feb 2017 15:09:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12775 invoked by uid 89); 6 Feb 2017 15:09:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1703, H*MI:sk:22cf411, H*f:sk:22cf411, H*i:sk:22cf411 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Feb 2017 15:09:13 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cakul-0007Nl-Qn from Luis_Gustavo@mentor.com ; Mon, 06 Feb 2017 07:09:11 -0800 Received: from [172.30.11.152] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 6 Feb 2017 07:09:08 -0800 Subject: Re: [PATCH,v2] Make language setting tests more robust References: <1485962220-31071-1-git-send-email-lgustavo@codesourcery.com> <1485980466-711-1-git-send-email-lgustavo@codesourcery.com> <4423d3ac-814c-2d71-e5fd-ed27368f02e1@redhat.com> <22cf411e-ba69-723d-8289-71b636313c39@codesourcery.com> To: Luis Machado , Pedro Alves , CC: Reply-To: Luis Machado From: Luis Machado Message-ID: Date: Mon, 06 Feb 2017 15:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <22cf411e-ba69-723d-8289-71b636313c39@codesourcery.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00120.txt.bz2 On 02/06/2017 08:54 AM, Luis Machado wrote: > On 02/02/2017 06:36 PM, Pedro Alves wrote: >> On 02/01/2017 08:21 PM, Luis Machado wrote: >> >>> One case of the warning being displayed happens when one has debug >>> information >>> for glibc, which may cause GDB to identify the frame as having an "asm" >>> language. Therefore setting it to something else will get GDB's >>> attention. >>> >>> This patch addresses the problem by creating a function in >>> lib/gdb.exp to >>> set the language. That function will also handle potential warnings >>> and check >>> to make sure the language was properly selected. >> >> Sorry to be a naysayer, but I'm not sure about this. :-( I recall >> fixing bugs >> related to gdb printing that warning when it really should not, or >> causing >> regressions locally due to breaking that logic, with the testsuite >> helping >> notice them. I worry that this would be hiding such bugs going forward. >> Can you name the tests that where you saw the problem you mention? >> Many of the tests >> you're touching are changing the language after starting gdb with no >> binary >> loaded, even. Those definitely should not ever warn. There are a few >> even that >> have "no prompt when changing language"-like messages. > > Sounds reasonable. I think i was slightly surprised that the message is > not coming from the command that sets the language > (set_language_command), but from some frame manipulation function that > gets called as part of determining the current language of the frame. Nevermind. I think the message is actually being printed from execute_command (), after the "set language" gets executed.