From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 29B88388A802 for ; Tue, 9 Jun 2020 13:05:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 29B88388A802 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-Ae-UkqyzPBCTOUncv8LF1A-1; Tue, 09 Jun 2020 09:04:49 -0400 X-MC-Unique: Ae-UkqyzPBCTOUncv8LF1A-1 Received: by mail-wr1-f70.google.com with SMTP id a4so8574583wrp.5 for ; Tue, 09 Jun 2020 06:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fXatoF3lF2aNk7jJGKDBuegiAyB6tReaieAZZx17m3g=; b=dRb4TFNuBqiC6oiAMvRCogeKB6o+ZrbkvQW8Hb52tEQOXDPXSeAqonFkOsubKWwo8g L+p/AMC2dEGbqmRYhu7Q/xses9GTsJsRgIAG0K5/aVu3jlauW9wG3MkIAS0BCV+IglMr Fi2kKfpeQdCKf15Lzn9UCvU4PLZYB/qSneDdCsESYNnABf2Li3nUp/ZdDBX+ZAss1l+c AQG2WGobDBb4IOxS/s9O+A44Hs7xGjuvZJw8dhwp2Jn/KI4tAY8759brx+FZ/GLbORzq aRvERB1JUo35riFWLEJEnPTz31SG8dTQ686jvTdFfN/PFJpVvxe9MRlGFIJg3Bi4moys Y+gQ== X-Gm-Message-State: AOAM531/XCXt2S293KWj0Z751FZcb4XAMa2vkgW1cdVN90jiom1sy80/ Hns9XvzXz7rpBAWto93BltPSMoNO/5YtkBPDkA5PKvwFHH1+zJ6RK8d4iPST5sN0ovkUMayoiCm RMubNEKzx/9cpB9bOc8OC0g== X-Received: by 2002:adf:82c9:: with SMTP id 67mr4710344wrc.149.1591707887743; Tue, 09 Jun 2020 06:04:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqnFIqmehBqD/CtOqWkJnzUeSUKJeKiVJHeY98EJ3RNCUu4ijK1liY8RRfOjmiulZGGE1PdA== X-Received: by 2002:adf:82c9:: with SMTP id 67mr4710320wrc.149.1591707887559; Tue, 09 Jun 2020 06:04:47 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u4sm2851450wmb.48.2020.06.09.06.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 06:04:46 -0700 (PDT) Subject: Re: TUI enhancement suggestion. To: Phi Debian , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: Date: Tue, 9 Jun 2020 14:04:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 13:05:13 -0000 On 6/9/20 8:55 AM, Phi Debian via Gdb-patches wrote: > Hi All, > > I patched the GDB TUI to fit my needs, I post here 2 pictures to show it. > If you think it can be useful I can submit the patch. > > In a nutshell the reverse video for 'point line' is not suited for my color > 'theme' I prefere a tiny underline that is more readable in my case. > > I you think it is worth it, I could post the patch, else I keep it for > myself (as usual) :) I don't object to the feature, however, I'd like to point out that I am surprised that you're getting that yellow background color behind "printf". How is that happening? It looks like a bug offhand, to me. See the screenshots attached to this: https://sourceware.org/legacy-ml/gdb-patches/2019-03/msg00295.html Particularly, the "after" ones. Thanks, Pedro Alves