From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2071.outbound.protection.outlook.com [40.107.243.71]) by sourceware.org (Postfix) with ESMTPS id 38D3E385781A for ; Wed, 9 Nov 2022 14:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38D3E385781A Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWCnuXKV2eWrpjcHkt6Pd8kVQEo2wVPiyh/f/VXcvOlbTRscPprz6jMLZIixHtJkDfyPq+3ZbLTq2G2zL84LwD+dwVtpAOFgKV0EEfXrU7jFdtju7cI+A1m6M687zN9HyIghy71D1/Ivr8KjoDFCBr6+eH/thqYS9SnGjlKWomP1OHLT3oVyfuJMTesA9Xqu2p/F/lluPQQCU2iilAitMOuEGHzi8qvSGywHG40+FDSVWry9kqa+K70crdzh49kmXYfJyDluh1OTpLjsinMheL73BGHAfB+rq6SlvWvwLwPL4mh0GpZ+Fplxu8A2jXEDx6efFpFEKErJrr7pkPylfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ByYtjLFiU2xIGBPZANBkaHJA/SEg7qj/g47ETvrutAc=; b=LdkNwACmcGl8IHzDRQuRuANKk+INb+elesL01mrwVp9S6/E6LAlDSrLZxW68iV7DhBJYs/r0SjE04q4bcCzxqCwchbe3LUl7HBHQUsRgTDWSty3byhQasS4hpNqvDXpyC9wxxfyzY7cMRjqpeQFK0Gdqqg75klbuoo0eB5d3FlCAXoGR4nIr/sMTgsdRB+ldV4L2Z2TUTaFVDgyGBHBzSnACk3l6A48FT/v30B3dJ9UvLU9tZXEwhSb0Zna5LD5mb0I4qUHjB7AZrPQVK4hB3aTtGwhAAErvkzyyJfvbXqX3qnAULcVcwJXMBoJYStEWhCd2D8+wU7f9ZL+zdkPcnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByYtjLFiU2xIGBPZANBkaHJA/SEg7qj/g47ETvrutAc=; b=cpoVriEc/uyoaFDQrQPqy1fyh+ZdtrIuPwnK/7JaMeZ+GdrBkosVByS2mOiZNOtnLYIm04W83H3e8dpEOYqryvKvJreU7OEMxLOSt1w2LwIU6nQOITlun+EfEdTaLzcQk/9f4GYtGhzQkutwZiCOroKH7QnB5+rRyMJSuMMUJ+4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by SA0PR12MB4591.namprd12.prod.outlook.com (2603:10b6:806:9d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 14:18:08 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52%6]) with mapi id 15.20.5791.024; Wed, 9 Nov 2022 14:18:08 +0000 Message-ID: Date: Wed, 9 Nov 2022 14:18:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] gdb/py-inferior: Keep inferior threads in a map To: Simon Marchi , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20221107184727.2228056-1-lancelot.six@amd.com> <21fcb251-3946-d180-c457-e996a31f9df8@simark.ca> Content-Language: en-US From: Lancelot SIX In-Reply-To: <21fcb251-3946-d180-c457-e996a31f9df8@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR10CA0008.namprd10.prod.outlook.com (2603:10b6:610:4c::18) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5745:EE_|SA0PR12MB4591:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c2210b2-c177-4a24-ab35-08dac25d3936 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V7fXHGFQ8IGzoPpbo++W568YkewzxyXl/j8l2p/s+45U1GdiMxP50aj8uLkClusL/2rgqwEzj0FYWpS+JgIO1Ofuq00O4MyiKO8wTgsSTovAsEHL+WRzCoZSKwU7sdzPV5MY1guz5b5FBhas+HuKTpIJKKW5hZWRWmS8mylgCTnZRtA4BuXBGWNQiHXqY8oEP54rmwHQCKV74qG7VDAYy3ah3w7V8UCIQt226GsxQJ+U51ha8d8usZ3ksEEP61XKTT5Jme8n9AWtE/1+NHMKzlqyZwpwEnl75uPbgomNhEyf7HcPwAnVXR4FKRPtINFhFZK3gMzX+nIEDEG2tIODDGJollRUq1Ny461nSTbZGfO1Kdr+NP7tt84SYnTLbwUCc6E+jxPcCOiEAoQuFUVjMqwANhJVB73ETTX3roUz0PytY1t/ioFyzc4PigxXUfu67+qx+PZ3aJQ/B49zaJYT/eXOaVq7HKWvN1vas1SstAJPQFxqRY2KGozSsb5T4+UL+fDEapy63Fb2taMdh1TO4jNC8VOpPMlAQ/Qp9SMzE6hMhFedk+7A3Hd1P5pFA7O/eNv1JwvFP5P/EK9V8vK/4PoJIV9aRYHI40r9340mbHXLhUimj1l1RZeRm2ogPMr6niKkaB43yJpluLeDjSUYi9K/Xw5VYHOApq9+GXJbSmDFI59HP7SxwxJc6HbT341mwZxYk6W/pzIliQsqIF3+K1oDEH6SoL2sPfQavflokPLIE/KbxpWxdZJa4vKjclHwIohHGg8hkVSrn7O86ua0Wh1rIdnhZFAhjqyMhR3nU5Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(376002)(346002)(396003)(39860400002)(451199015)(8936002)(41300700001)(5660300002)(6666004)(316002)(6486002)(478600001)(36756003)(186003)(2616005)(6506007)(53546011)(6512007)(38100700002)(4326008)(8676002)(66476007)(66946007)(2906002)(66556008)(31686004)(86362001)(83380400001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEhTaU9QTDU3QlZEQkdvQXlvWjQvZm9TWVN0eEdqMWZKeGE2L3R5SXBSVXBY?= =?utf-8?B?NEF6cTNsNFZXYTd2b0k3NVE1TmU2Y0VUMUU5dmxxd1hRTEVsdHpIRE1LY2lU?= =?utf-8?B?VEVRUzBqVEJIQWtuQzdEd2dBRVVEUWM5SFF0WTBYWEUweStzYnp2NmNQa2RJ?= =?utf-8?B?WGRkanRzSnJiOGI2Z0ZMeVp2OGxabWg1SWNURzhEdEVkczdLbThpdlRXVnZn?= =?utf-8?B?ZnhGMTIrUVdPcHZ1bmc1eU9NSnNZNnFiTUlob1Z2UCtUOWxEakNqb3VkcS83?= =?utf-8?B?UUQ2VGxRWnpXWTdlR1BnQkovTHE4NWFhbklQeVJIa0VLY3h1K0NaSjhiNlZt?= =?utf-8?B?T0VNeTQ5YmxzYVJoVHZxcXUrUHdiWE4xUUo5NVlpamVBbStKcmF3cHBXUDZN?= =?utf-8?B?cmdsQWdCbmlUcTl6L1Z4cURyd0tPbzF1OHdocllydVRHSW45dGgzMFBla2VP?= =?utf-8?B?bzZhdWxabHQ3TEd5aEhLOVcxNksvSG4xeDFIVHdqM3g2NUJiajdRbWtFYk1r?= =?utf-8?B?dlRYNEgxWlZDeXBpYTNDWkdNcmJpVGhSWFZ6OGRsKzBDb0Y4bDZsNGNqbjdx?= =?utf-8?B?Q3R6MDdqTWh1NHJhL0dIdGdCNkp1bFFkTnFvN0V6UzFNL2hlYWYydlEwaHNh?= =?utf-8?B?Q0pRMjQwZlZIRmVsVkhZZEI4WDlDeFZGdExNTHdPUzFETjV4alZNbEVQSXB0?= =?utf-8?B?S0hyTnpuMTJrVkd5TWMwSFVIMzdNeXNtV2xyblpUOHhpOFlnM2R5c2RpamtT?= =?utf-8?B?eG5ldXQ4dnVyTWd4c21QOVhoVEFOUGdCcVZkVHBBWGZudVk3WmdIamNuMExI?= =?utf-8?B?SzdybmdONmt6OU1GUnNJSFNTT0dEbUMyNm04SE5yakl0TFJNM1l5eC9DK0Uv?= =?utf-8?B?SnZXdFV0RG9TcFVKbG9hdDArRjZOdG1oL3pCOUc0U21aZnN4TEVvdzUycktJ?= =?utf-8?B?K05Gcis1UGsrSVRqQXA3L0JyRUo2aUxtNk5FYWtWZUVxRnNHT2w0dUlPTHQr?= =?utf-8?B?WUxOZjd4MngzMTgyNk1kQnRLS21BN1pZSC9CdjB6UE8rQnhzZ01EbDIxOS9Q?= =?utf-8?B?ZzgrU2FmbTBaSVErMkRNTWZpK0hJek5MeUt6d3VRVVNBckw3MDdvR0lxRnpr?= =?utf-8?B?MjNhckFqUGFmWUpNSlU4WXVqcWJtbE4rWWphUXF6ZkpacG41dHdPcWc4ODRh?= =?utf-8?B?dDhVUEFmS3NqTU43WEZnMDcyRTJxbzhjSVhCM21WV0wyTkdMZlh1bnBFcEVv?= =?utf-8?B?QVFVN0pvcTJZT0JmUzBqdHhWQWtFd2RRSldGSFU1Umo1ZTB6ZzVJdEgvTHBO?= =?utf-8?B?cFR0YklCc1FqTjBWa0FOZllQTHF0Y09UaEM2Szg4R2xIajhocVAvMVF2S3RN?= =?utf-8?B?NHJOYTVGRTdFOFY5QmQvMWo3dUtxTzYreUtXa2JnejhwNlRXdUo3Wnh2aDBS?= =?utf-8?B?TEdzcmNRYnlROERFM2xnVU1wZnR2RFppd2hCVWpTekZva2JMYVpIaVFBNFdz?= =?utf-8?B?N0t3dmRHMWdyVXNNTGdPRU45VEVBRDdHMEVqZExkVzcrcmUrTXlzK0pZK0M4?= =?utf-8?B?ODN1b0E3ejBpRHVqTmZXQUNSdTROQTh3cWJQZXY4Y2tQQUNIMy9KanBvWE11?= =?utf-8?B?Z2F6WjdyUHM1a3ZhSnMzOTJlQ0l3VjJSWFNXazIxOGhKREpiK0MyYzRKSG15?= =?utf-8?B?WXVodHdBQURmd1lJV0lsbndiYWdkb3EzNW5DYlRrVUtlY2t1ejJlbW1yWVVS?= =?utf-8?B?UmJ2T2VFVWZaS2JvVE40ajBFTW5BNnJKYTBpdnc2ZGVnVWZ1eGJMRUtGRWJJ?= =?utf-8?B?cDh1TjJOUVdxdmdhU1Fja1dNUU5EV1FJNHdablU4Ukl1RDFyMVJmbXpQTWNv?= =?utf-8?B?TzBEUFRib0VySlVlOStTcGljb250LzJLakVOaHlzWTJlNGdoWTFvdWlsdDk4?= =?utf-8?B?KzlZRXRQZ3A2dGllaFMyZ0JJZjFoamFyU2FDQUhMcVFhK0loNGRTVS9kRUd0?= =?utf-8?B?SVBIVDhhZnZpY1dLUUplWkFxWEFxU05JQVBGQXBaRW5Qb3JDNmFyQ2RlVnVJ?= =?utf-8?B?WXhwdDYrTUR2MnJ6MUxvQ3NDTkFmK0I4MzB0TnUydEtzWHZSUVU3Y0NpdXcy?= =?utf-8?B?Zmo5cERXeUdtK2ZqV3dTMUwwWnJydDdLR2hwSTVyZXZqM2szcnIxeHZrd3Fh?= =?utf-8?Q?1v8wIrP4N6OO9jxlAffL6+g=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2210b2-c177-4a24-ab35-08dac25d3936 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 14:18:08.0851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P4pKRqtp4FqTXhkVakCkn1PjdULVlNjxC20C4Px9xSfkNNKi6t1RuDYEL23yvz9rF0aRco860X7eQB5sBN9MEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4591 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/11/2022 21:44, Simon Marchi wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On 11/7/22 13:47, Lancelot SIX via Gdb-patches wrote: >> diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c >> index 8847a6d9308..9fd5f30fcdb 100644 >> --- a/gdb/python/py-inferior.c >> +++ b/gdb/python/py-inferior.c >> @@ -30,17 +30,9 @@ >> #include "gdbsupport/gdb_signals.h" >> #include "py-event.h" >> #include "py-stopevent.h" >> +#include >> >> -struct threadlist_entry >> -{ >> - threadlist_entry (gdbpy_ref &&ref) >> - : thread_obj (std::move (ref)) >> - { >> - } >> - >> - gdbpy_ref thread_obj; >> - struct threadlist_entry *next; >> -}; >> +using thread_map_t = std::map>; > > You probably want to use unordered_map, which is preferable when we > don't care about key order. Will do in the V2! Thanks, Lancelot. > > Every time someone introduces a use of a map, there's the topic of "but > hashtab is faster than std::unordered_map" that comes but, and the fact > that gcc has some C++ bindings for it, and that we should import and use > it, but that it was never done because its "empty" method confusingly > empties the map, rather than returning whether the map is empty. But > still, I think that std::unordered_map is preferable over std::map. > > I haven't checked the rest of the patch, since Tom already has. > > Simon