From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: donb@codesourcery.com, simark@simark.ca, palves@redhat.com,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCHv6 1/5] gdb: Remove duplicate declaration of global innermost_block
Date: Sat, 20 Jan 2018 21:34:00 -0000 [thread overview]
Message-ID: <ab42929618a5e93818bd99334c51ed9063dc174d.1516483641.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1516483641.git.andrew.burgess@embecosm.com>
In-Reply-To: <cover.1516483641.git.andrew.burgess@embecosm.com>
The global 'innermost_block' is declared in two header files. Remove
one of the declarations, and add an include of the other header into
the one source file that could no longer see a declaration of
'innermost_block'.
gdb/ChangeLog:
* expression.h (innermost_block): Remove declaration.
* varobj.c: Add 'parser-defs.h' include.
---
gdb/ChangeLog | 5 +++++
gdb/expression.h | 5 -----
gdb/varobj.c | 1 +
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d2d44725a02..7d7d10661ea 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-19 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * expression.h (innermost_block): Remove declaration.
+ * varobj.c: Add 'parser-defs.h' include.
+
2018-01-19 Tom Tromey <tom@tromey.com>
* rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
diff --git a/gdb/expression.h b/gdb/expression.h
index a783ea5fef2..030f2f08e7a 100644
--- a/gdb/expression.h
+++ b/gdb/expression.h
@@ -111,11 +111,6 @@ extern expression_up parse_exp_1 (const char **, CORE_ADDR pc,
attempt completion. */
extern int parse_completion;
-/* The innermost context required by the stack and register variables
- we've encountered so far. To use this, set it to NULL, then call
- parse_<whatever>, then look at it. */
-extern const struct block *innermost_block;
-
/* From eval.c */
/* Values of NOSIDE argument to eval_subexp. */
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 01dabef37c3..701ef663766 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -30,6 +30,7 @@
#include "gdbthread.h"
#include "inferior.h"
#include "varobj-iter.h"
+#include "parser-defs.h"
#if HAVE_PYTHON
#include "python/python.h"
--
2.14.3
next prev parent reply other threads:[~2018-01-20 21:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 13:27 [PATCHv4 0/5] Fix -var-update for registers in frames 1 and up Andrew Burgess
2017-10-19 13:27 ` [PATCHv4 3/5] gdb: PR mi/20395: " Andrew Burgess
2017-11-12 20:49 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 2/5] gdb: New API for tracking innermost block Andrew Burgess
2017-11-12 16:26 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 5/5] gdb: Don't store a thread-id for floating varobj Andrew Burgess
2017-11-12 21:00 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 4/5] gdb: Remove out of date comment Andrew Burgess
2017-11-12 20:57 ` Simon Marchi
2017-10-19 13:27 ` [PATCHv4 1/5] gdb: Remove duplicate declaration of a function Andrew Burgess
2017-11-12 16:00 ` Simon Marchi
2018-01-02 15:31 ` [PATCHv5 0/5] Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 5/5] gdb: Don't store a thread-id for floating varobj Andrew Burgess
2018-01-20 21:34 ` Andrew Burgess [this message]
2018-01-20 21:34 ` [PATCHv6 2/5] gdb: New API for tracking innermost block Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 3/5] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-21 0:45 ` Pedro Alves
2018-01-20 21:34 ` [PATCHv6 0/5] " Andrew Burgess
2018-01-20 21:34 ` [PATCHv6 4/5] gdb: Remove out of date comment Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 5/5] gdb: Don't store a thread-id for floating varobj Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 3/5] gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up Andrew Burgess
2018-01-16 16:34 ` Pedro Alves
2018-01-02 15:32 ` [PATCHv5 4/5] gdb: Remove out of date comment Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 1/5] gdb: Remove duplicate declaration of global innermost_block Andrew Burgess
2018-01-02 15:32 ` [PATCHv5 2/5] gdb: New API for tracking innermost block Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab42929618a5e93818bd99334c51ed9063dc174d.1516483641.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).