From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] nat/fork-inferior: include linux-ptrace.h
Date: Wed, 27 Jun 2018 16:32:00 -0000 [thread overview]
Message-ID: <ab4ed334-3bd2-1599-3a66-156d61951b70@redhat.com> (raw)
In-Reply-To: <e8796d50201798bad013ff9649c9b21e@polymtl.ca>
On 06/27/2018 03:34 PM, Simon Marchi wrote:
> On 2018-06-27 10:31, Thomas Petazzoni wrote:
>>> fork-inferior.c is also included in native builds for BSDs, AIX, Solaris
>>> and Darwin (see gdb/configure.nat). I am a bit concerned that
>>> linux-ptrace.h could use some Linux-specific things, and thus would
>>> break the other builds. However, I built-tested on FreeBSD and it seems
>>> fine. Worst case, we can probably wrap this include in "#ifdef
>>> __linux__" if that becomes a problem.
>>
>> Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should
>> be replaced by a proper autoconf check testing for the availability of
>> fork().
>
> Agreed, and I think Pedro will agree too (unless you can think of a simpler solution that doesn't involve autoconf?).
That does sound better.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-06-27 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 8:05 Thomas Petazzoni
2018-06-27 14:25 ` Simon Marchi
2018-06-27 14:30 ` Pedro Alves
2018-06-27 14:31 ` Thomas Petazzoni
2018-06-27 14:34 ` Simon Marchi
2018-06-27 16:29 ` Joel Brobecker
2018-06-27 16:32 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab4ed334-3bd2-1599-3a66-156d61951b70@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).