From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) by sourceware.org (Postfix) with ESMTPS id E9FF83857004 for ; Mon, 12 Sep 2022 10:20:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9FF83857004 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LvToYJI9k+Ew5C8uy2cDuel2milFZIcXneS53GfI2IdC400Zrayj+1gmY8DIDifpvl2imjZufqSLedt0J60WTiWJ3pe/umdi/FEqgX3LT8ScvRqYK6aTpDU6XAYNrpDiC8xXAVYnHqECK6sTGhmCr0z92w5F9V+ptn9MYhmUvJKMhdIxy4/bgwl6ktG7Z/5SNAguAfbRJ/I9HbzWQn6YTZKsrtFqrUzE3Lt4bko1kdpytwyNywddIa14Y16Pd/1RqDZtceRPXdGWP5hzWgRGt2uM2UgjiZjryyGoGoeozi1h3JhGrktMXe8yazmcpGIJ7QgKKNRqaa9ScUqNzFAnkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z1FTvcyleYYnzA82sY9ZEBMTz8tPWMRKg7EWnPhX1LI=; b=nmSlAwWFg86XdBH1aMXmDhdhK01ulzzhnm1758cJWYFZbrPC8mw6Jj8kn3J7QAZo6ujyNr02egxb+VJix6MmbBNu4Yk9mZU25dinBSFXe99iSt0PTHsTLUjrQ1gkHRXzB5nUx6vSbg3lWNPOtt8URkxbDmIFA3j5tsZrkJjyt22TxH42k8fNyjDV4ZoLD5hLO4olV7X7KSATlgJ+DP7C0PtODXG81WICyrm8cMCy531oow5rDF0Qu3qZsCBrAa5A9L2QNibuJ2nt9NWb1s3sWJRM3MqKToOYUX6KIvLNIKGCE5b0TnVyDrKE6HDWSIcjQUK6peUdxKsTuKwzdr6ieQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS8P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::19) by DBAPR08MB5768.eurprd08.prod.outlook.com (2603:10a6:10:1b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Mon, 12 Sep 2022 10:20:10 +0000 Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:330:cafe::b0) by AS8P250CA0014.outlook.office365.com (2603:10a6:20b:330::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22 via Frontend Transport; Mon, 12 Sep 2022 10:20:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Mon, 12 Sep 2022 10:20:09 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Mon, 12 Sep 2022 10:20:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0a06d140c29f110d X-CR-MTA-TID: 64aa7808 Received: from c23703cc36f5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 74E256AA-56E7-4F92-A691-7A9F6F3E941D.1; Mon, 12 Sep 2022 10:20:02 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c23703cc36f5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 12 Sep 2022 10:20:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mn7QAPDa1WpVviOAaWjaY1J9Ll0HA8RuKHvjxWd69dm+REaB9ih4sAodCN51HeZ0Hop+ENq9iPWXBOwOFxbaglmGms5S4xDPXRRc+bSbHxWUKW6y0gXtk4W1xQzGCYj1S97t5IBWgB6L/NFDDW+R+yQ0QQ4Dwy0iX4CKCFrOuTDBAducoroC4rkV29DlTxrhyFBF0w7uzoo6ftT6K2JaDGkBM0d6JRd901Z3P9tc6PWP1n2PkB7Pznpa0XuyNgYFIrYNihRShieP/DfQJfy/0jZmcFDwSWVKdN+YtIRXkBu2Si9khwGjpdJSkTNcc4Vn+x6UUoVSD10y1FcHk58n+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z1FTvcyleYYnzA82sY9ZEBMTz8tPWMRKg7EWnPhX1LI=; b=S0uhWfC2t5+9lx8V6jxYPiUgv3twwWpszN4KK01uIdB/uPMw5cJU+FK/GZsLQ3Xj2xb4gxOSjm7tn9Dw0jdCWtH72yUMLczxswQNUZcMtt6w+Od5i96cOo50kidyK4VI45oSvqsfQ+nEEhywdenl2/F/WrwF+nLU9sP3yYDwe2EYa3c+/mF2qvhqhv6dACUEyXwDARYZnUQu5jCsykON7EjFpdb+gnxn6a3qGViJOjXOS5vlPk3N17ROVd3zaFDOygmZ6aVx2FRde3TNTieaWxB4TrVkuj6KyoPJL8IJ2yBeiBfB4RYmbraeNVLxZDBhm5cQ8hoSsKFilD3LxdI9ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB6550.eurprd08.prod.outlook.com (2603:10a6:20b:31b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Mon, 12 Sep 2022 10:20:01 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 10:20:01 +0000 Message-ID: Date: Mon, 12 Sep 2022 11:20:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] [gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp for ppc64le Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20220901140905.24562-1-tdevries@suse.de> <20220901140905.24562-2-tdevries@suse.de> From: Luis Machado In-Reply-To: <20220901140905.24562-2-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0657.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::6) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB6550:EE_|VE1EUR03FT033:EE_|DBAPR08MB5768:EE_ X-MS-Office365-Filtering-Correlation-Id: cca51f9c-c4cc-45c8-c5ff-08da94a85f1f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oibDX4xid98IY+QA4XyVICFdqIz7EH9q1m6QmpGpk2r2FSkHtMlYX+bPgcpEvDE0swJLHSLrn99j108LAF8h9fLQLqKzYkBxQDum6yJ61P5q74Qvh3UdcmAkflT9DbFgBS+tQFv9NChr6sWIMBFNcYeamoweDBcwGDcqkDsX0x+OWiOsgEtRGV2k0ZjsZNHs3MRgZdoSX2shFiBE+Gub3OOSztSk79rsk5AVZnFS4MTADUOYUHMq7Wji4AAIc+0kSBRvlHdbJ5XoIhrDtpIZP2yaenlHQHcQO5yrR8x3kutIbHEt1oMnjbiT5SLBzhnrz9zq8LEWSGlhVwEbUywK0z6VNvfZKhojuMorG8DxQuLJRIOyI113zdIb9bVPmOG/WMHAwU0Rov9BvwLJ4NffLscjwjRmJ50KxA72EpyQLwwLIJWOmiqVwhKcRtanj+6mAn3bBAA78iZ+TujrGDFM31IfSfzgM0/MbTB43ACtlDe2d8Ytw303KWpEFHbFmEVKouNJX6vLKkBYDMCW0IGyfTpnbfMpvxGgHXvdmfo4ILEKtHCQXckVpQD3mQVIfVJ9RLItan5O3oxmJ/Nd4HxNqWKkIcI3WuusYSKw6xvU/9H366A475ZADggedHPPsMAvXaknTMQpXxPbd4s9aWmVCmdITYmXUh/Q/e4nGUcFAAwaoQBmaEccwJWxYxbF5wa9kNwjHSPtsGqd9l56aaCTJgddXY0stZsKtzUczyb16XJfmZ3ZDxt9L7YeCuhBytvCMLxq6/HN6ALSxoirTDdUUFarufnjCW7iHNAVu6MipFg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(38100700002)(66556008)(31686004)(8676002)(86362001)(31696002)(66946007)(66476007)(36756003)(83380400001)(186003)(2616005)(6506007)(41300700001)(6512007)(26005)(53546011)(478600001)(6486002)(2906002)(316002)(44832011)(5660300002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6550 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4c58d1f2-1810-402f-beb6-08da94a859fc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /a5oa+es3bYSFIIVrotHMgJaIqiYwZzHvYnuavw5FGnjtTdSKg/5XnKNQsdDvxZhZOkmi18errPT6PhW5y7AeAw1IhCNdYHzlMhwRfFNIPQCmTgYOXt8t3Dbd0itMh9AR6u3LQzeUSjkgV55lX9Pf/SiwpOBuk5xB891t9EbS8ioTBIlz1c7yP6hGa2GIZ/kpEsF1Ntd0KKHIVb9zGGiW/ySFyXm+rYCGWb03IXHCFX2HIhGezWPz4EqivJNsXsI/kohFsAhO9Zvv1puppEfzd6Rs+LWYIySquOkIsn5GQ3L5wk/HaltyuBqRUOq8e+RiP/0M16aa2Y9c40NRaf4xEZejlE77GodNkSFO2keIAjHXYyNnlUsDmuNU50Jz8f5VbZdvtOzmf0rkJjpPXwg8I4aMSlNk7uvi1t7G1POAqg2I2dy4Rl5kpcGm69IL5VgXC+Uma/eIDQyDsc4vD8fNRMPayHrw2RF0q8a/IhpmDuR919HqpxkZPc6x9wTRAg0UkYBWfcZdwziVQcFADNqNVzlOsqFQPZZzjRCBMaxtEcZbezXqCvicuwX/+7WXa0ygfwUAprDUYAI9n01jKs4U6fSmrs9tXKiv/3Ev3cZ5nJlKIu0uAuXk7QK1mjhAQ6CYqUqbJicVJFvfUzWV/iPJdhdmKwdBQflvCkWWJ7ULuoFt+s9FdprtGXA4GV7Yf5DFqN4LosTVMCrL8gGj7tpndDeLOkX9gC61qpsZ/LqNyN7s1RRoYAo6cowPs6+//Xkt0T/nyk+iP4e+PR502MKMg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966006)(36840700001)(47076005)(336012)(6512007)(6506007)(53546011)(41300700001)(478600001)(6486002)(26005)(83380400001)(186003)(2906002)(2616005)(44832011)(5660300002)(8936002)(82310400005)(316002)(40480700001)(70206006)(70586007)(31686004)(8676002)(31696002)(36756003)(81166007)(82740400003)(356005)(36860700001)(86362001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 10:20:09.6274 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cca51f9c-c4cc-45c8-c5ff-08da94a85f1f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5768 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 10:20:16 -0000 On 9/1/22 15:09, Tom de Vries via Gdb-patches wrote: > In commit cd919f5533c ("[gdb/testsuite] Fix > gdb.dwarf2/dw2-dir-file-name.exp"), I made gdb.dwarf2/dw2-dir-file-name.exp > independent of prologue analyzers, using this change: > ... > - gdb_breakpoint $func > + gdb_breakpoint *$func > ... > > That however caused a regression on ppc64le. For PowerPC, as described in the > ELFv2 ABI, a function can have a global and local entry point. > > Setting a breakpoint on *$func effectively creates a breakpoint for the global > entry point, so if the function is entered through the local entry point, the > breakpoint doesn't trigger. > > Fix this by reverting commit cd919f5533c, and setting the breakpoint on > ${func}_label instead. > > Tested on x86_64-linux and ppc64le-linux. > --- > gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp | 8 ++++---- > gdb/testsuite/lib/gdb.exp | 7 +------ > 2 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > index 08b5c645fa2..053f7229537 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > @@ -450,20 +450,20 @@ proc test { func compdir filename } { > error "not absolute" > } > > - gdb_breakpoint *$func > + gdb_breakpoint ${func}_label > gdb_continue_to_breakpoint $func "$func \\(\\) at .*" > > gdb_test_no_output "set filename-display absolute" > verbose -log "expect: ${absolute}" > - gdb_test "frame" "#0 $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute" > + gdb_test "frame" " in $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute" > > gdb_test_no_output "set filename-display basename" > verbose -log "expect: [file tail $filename]" > - gdb_test "frame" "#0 $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename" > + gdb_test "frame" " in $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename" > > gdb_test_no_output "set filename-display relative" > verbose -log "expect: $filename" > - gdb_test "frame" "#0 $func \\(\\) at [string_to_regexp $filename]:999" "relative" > + gdb_test "frame" " in $func \\(\\) at [string_to_regexp $filename]:999" "relative" > } > } > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 17523f82996..2f1147159ad 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -787,14 +787,9 @@ proc gdb_continue_to_breakpoint {name {location_pattern .*}} { > global gdb_prompt > set full_name "continue to breakpoint: $name" > > - set re_at_in " (at|in) " > - if { [regexp $re_at_in $location_pattern] } { > - set re_at_in " " > - } > - > set kfail_pattern "Process record does not support instruction 0xfae64 at.*" > gdb_test_multiple "continue" $full_name { > - -re "(?:Breakpoint|Temporary breakpoint) .*$re_at_in$location_pattern\r\n$gdb_prompt $" { > + -re "(?:Breakpoint|Temporary breakpoint) .* (at|in) $location_pattern\r\n$gdb_prompt $" { > pass $full_name > } > -re "\[\r\n\]*(?:$kfail_pattern)\[\r\n\]+$gdb_prompt $" { Looks like this makes the testsuite go from PASS to FAIL for aarch64. Are we still stopping in the first instruction and ignoring prologues?