From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77934 invoked by alias); 13 Apr 2017 13:25:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77902 invoked by uid 89); 13 Apr 2017 13:25:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sim, simulator, our X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 13:25:31 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cyekd-00022F-Vj from Luis_Gustavo@mentor.com ; Thu, 13 Apr 2017 06:25:32 -0700 Received: from [172.30.1.10] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 13 Apr 2017 06:25:29 -0700 Subject: Re: [PATCH v2] Define an error function in the PPC simulator library. References: <20170405163332.82109-1-jhb@FreeBSD.org> To: John Baldwin , Reply-To: Luis Machado From: Luis Machado Message-ID: Date: Thu, 13 Apr 2017 13:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170405163332.82109-1-jhb@FreeBSD.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00420.txt.bz2 On 04/05/2017 11:33 AM, John Baldwin wrote: > Previously this used the error function from GDB directly when linked > against GDB instead of the error method in the host callbacks > structure. This was exposed via a link error when GDB was converted > to C++. The error function invokes the error callback similar to > sim_io_error. > There is another implementation of error (...) in sim/ppc/main.c and sim/ppc/misc.c. Should those be kept as is or should we only use the new function you're providing? Also, i don't see error being implemented in the other sim backends. I wonder if we should just use whatever is available (sim_io_error?) instead of supplying our own ppc-specific version?