From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 5200F383E811 for ; Fri, 15 May 2020 20:07:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5200F383E811 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-FUfXkjagNiKNZ_BIkPcqWQ-1; Fri, 15 May 2020 16:07:17 -0400 X-MC-Unique: FUfXkjagNiKNZ_BIkPcqWQ-1 Received: by mail-ed1-f72.google.com with SMTP id m7so1382238edr.5 for ; Fri, 15 May 2020 13:07:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MbDXvS4iEue5N3pBg/XtSUcZf1R6iDW4NpDTjaFNtyo=; b=af0s3/7YLZmRjcsQZ9p3/OUbSR7Q6E4fOqZSQISeo679q1Tq1CIRqI9D56MQ2urIyM 6D/mou4ZEReJvDliqV2H64wKUcEbI2hRzjShrYyWxj2dravM/sIu7PLBJbEJq06jdfWA mYDDgklOWvU3C+VgiHnecZbRTPfQuqtIZqtKb+PJgceDD3j8umJI6m69/nh7pNLjmj2O gdtc1KpstW8wCUR+hywvNVYSMDYtzUjXqjxI4UQL2OobsNVgJKb6MpZFUjUcnKs9AEOU wSoR74Fja8f2UksfOBC4cazlDIYV2JOJU9m2ifXY+wXUnAJQ+JJPq/RaBheR22rxbe57 QNPQ== X-Gm-Message-State: AOAM533MoQejG6zB8kyIK9twIzJjy3uCBvoMoIng+uveViQV0DMv3QT2 bggiJeJO7g+tQVgKhDNjpUtz9I144Waex1OmaA98Ar/gM8heLsr+av4l45YgM2KqjXIV54f6lFp Qls9FBULFzvN1/XBdYJBMTA== X-Received: by 2002:a17:906:2b96:: with SMTP id m22mr4476118ejg.330.1589573236089; Fri, 15 May 2020 13:07:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkXYTZBo2piqXW/hnZUUMiWCz15Y2P8q7da91P9l7TgBLZwRMj3wazFoyxa0uo9HivMBJgDg== X-Received: by 2002:a17:906:2b96:: with SMTP id m22mr4476106ejg.330.1589573235900; Fri, 15 May 2020 13:07:15 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id n7sm311544ejj.17.2020.05.15.13.07.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2020 13:07:15 -0700 (PDT) Subject: Re: [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board To: Simon Marchi , gdb-patches@sourceware.org References: <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca> <20200510155937.1064329-1-simon.marchi@efficios.com> Cc: Michael Weghorn From: Pedro Alves Message-ID: Date: Fri, 15 May 2020 21:07:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200510155937.1064329-1-simon.marchi@efficios.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 20:07:20 -0000 On 5/10/20 4:59 PM, Simon Marchi via Gdb-patches wrote: > gdb/testsuite/ChangeLog: > > * lib/gdb.exp (gdb_run_cmd): Change argument from args to > inferior_args. Pass it to gdb_reload. > (gdb_start_cmd, gdb_starti_cmd): Change argument from args to > inferior_args. > (gdb_reload): Add inferior_args argument. > * config/gdbserver.exp (gdb_reload): Add inferior_args argument, > pass it to gdbserver_run. > * boards/native-gdbserver.exp: Do not set noargs. > * boards/native-extended-gdbserver.exp (gdb_reload): Add > inferior_args argument. > * boards/stdio-gdbserver-base.exp (gdb_reload): Likewise. > * gdb.base/a2-run.exp: Check for use_gdb_stub. > * gdb.base/args.exp: Likewise. Woohoo, finally! LGTM. Thanks, Pedro Alves