From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by sourceware.org (Postfix) with ESMTPS id 739433856962 for ; Mon, 13 Nov 2023 14:13:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 739433856962 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 739433856962 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884835; cv=none; b=T2xVEAkpxKK/hejx9BEEWxDYEgMrcn86PVlpoQmxq26vfFM03o1kfPfeLkQxx+zM8X9JYKxbnKdoqDp4KBkSykPRTrFY+HeMSSXUPWRhrgmghCSMgLL7dK0K2szteziqh58KHMWyq0p08pEzFOc8g+8bHo4Q/1GEvQPgpLS9BGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884835; c=relaxed/simple; bh=R6pvoMFY0hBQkk4zGaAhjlETpZenpeD4tCyoOVajYJA=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=SCa3Hz6M+Yrs0DRWoo5kfKsnMLXkS43Iv+Kvfd3dX5ZqM4uwLB+wrQU4htauwM6PKOq9J5tQMzcAVUXYXt81SlZTFbiNG31whLE+uB1sOonNMtAN1HWOQ/zJ0reg4oJZ9Qwxmu8Qz/GGlpOTFu8sSlesTbHhRlSQWdp+wTanYXw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5094cb3a036so6171281e87.2 for ; Mon, 13 Nov 2023 06:13:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884832; x=1700489632; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EFcblQgBiOndByRpTowM8aOZbps1XxkZBeQdoaMy8uM=; b=xGhl1OuN/Q6MRdZoIJx5sU6c0RKO7FA3mFJIq56nAayRRaAZze44TbY3QX+dPF1yu0 GaDbSgpoXa4MbVXnisWh72qyzZaUMHLkmL/5oEkaXo5LUs/rsLxoLRaUGWZVlndvNjQj UBFoSRWkHMiaDNrHqr+ybW7oYGepFirlZxvho8dAnnuSR9+bc9WPAaUWxVCKPJ/WJCmn dXUAtbjMcAnSfg6GEbot5XfgfaEE9gRFjR1iMETAlZuc8HZHs/lOeXPBSnnJvmiWgwMQ 4vN9s4ofgQqFE071YDbmsd+bq3klCN176tSGKchTVbUGdBnYvihNjoUyDqa47YL9EEzi b3rA== X-Gm-Message-State: AOJu0YwfSWvPy5XLL4seKy/m2YyNDMT15gkBGnW0TjCcABHeAskxTrtT 1RQOBHf4nu0pJ13e5Ekj6WY= X-Google-Smtp-Source: AGHT+IEqiGQZ4P89LeitJweXyaKRTIqjFWvfeQ7rWRigXh3fEvzCzeZw0M1BsCd5FWvWgZiINEcMZw== X-Received: by 2002:a2e:95d5:0:b0:2c5:1d95:f7a1 with SMTP id y21-20020a2e95d5000000b002c51d95f7a1mr4245179ljh.27.1699884831899; Mon, 13 Nov 2023 06:13:51 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:8060:1e54:fb28:9635? ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with ESMTPSA id he9-20020a05600c540900b0040a48430837sm9830701wmb.13.2023.11.13.06.13.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 06:13:51 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 14:13:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 28/31] Document remote clone events, and QThreadOptions packet Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org Cc: Eli Zaretskii References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-29-pedro@palves.net> <87ttvl3nyt.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87ttvl3nyt.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-05 16:53, Andrew Burgess wrote: > Pedro Alves writes: > >> This commit documents in both manual and NEWS: >> >> - the new remote clone event stop reply, >> - the new QThreadOptions packet and its current defined options, >> - the associated "set/show remote thread-events-packet" command, >> - and the associated QThreadOptions qSupported feature. >> >> Approved-By: Eli Zaretskii >> Change-Id: Ic1c8de1fefba95729bbd242969284265de42427e >> --- >> gdb/NEWS | 20 +++++++ >> gdb/doc/gdb.texinfo | 127 ++++++++++++++++++++++++++++++++++++++++++-- >> 2 files changed, 144 insertions(+), 3 deletions(-) >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 0aa153b83da..b1d3dd7e7d9 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -160,6 +160,10 @@ set style tui-current-position [on|off] >> Whether to style the source and assembly code highlighted by the >> TUI's current position indicator. The default is off. >> >> +set remote thread-options-packet >> +show remote thread-options-packet >> + Set/show the use of the thread options packet. >> + >> * Changed commands >> >> document user-defined >> @@ -285,6 +289,22 @@ GNU/Linux/CSKY (gdbserver) csky*-*linux* >> >> GDB now supports floating-point on LoongArch GNU/Linux. >> >> +* New remote packets >> + >> +New stop reason: clone >> + Indicates that a clone system call was executed. >> + >> +QThreadOptions >> + Enable/disable optional event reporting, on a per-thread basis. >> + Currently supported options are GDB_THREAD_OPTION_CLONE, to enable >> + clone event reporting, and GDB_THREAD_OPTION_EXIT to enable thread >> + exit event reporting. >> + >> +QThreadOptions in qSupported >> + The qSupported packet allows GDB to inform the stub it supports the >> + QThreadOptions packet, and the qSupported response can contain the >> + set of thread options the remote stub supports. >> + >> *** Changes in GDB 12 >> >> * DBX mode is deprecated, and will be removed in GDB 13 >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 5e75f32e0cd..ef62fac366f 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -24079,6 +24079,10 @@ are: >> @tab @code{QThreadEvents} >> @tab Tracking thread lifetime. >> >> +@item @code{thread-options} >> +@tab @code{QThreadOptions} >> +@tab Set thread event reporting options. >> + >> @item @code{no-resumed-stop-reply} >> @tab @code{no resumed thread left stop reply} >> @tab Tracking thread lifetime. >> @@ -42110,6 +42114,17 @@ appropriate @samp{qSupported} feature (@pxref{qSupported}). The >> remote stub must also supply the appropriate @samp{qSupported} feature >> indicating support. >> >> +@cindex thread clone events, remote reply >> +@anchor{thread clone event} >> +@item clone >> +The packet indicates that @code{clone} was called, and @var{r} is the >> +thread ID of the new child thread, as specified in @ref{thread-id >> +syntax}. This packet is only applicable to targets that support clone >> +events. >> + >> +This packet should not be sent by default; @value{GDBN} requests it >> +with the @ref{QThreadOptions} packet. >> + >> @cindex thread create event, remote reply >> @anchor{thread create event} >> @item create >> @@ -42148,9 +42163,10 @@ hex strings. >> @item w @var{AA} ; @var{tid} >> >> The thread exited, and @var{AA} is the exit status. This response >> -should not be sent by default; @value{GDBN} requests it with the >> -@ref{QThreadEvents} packet. See also @ref{thread create event} above. >> -@var{AA} is formatted as a big-endian hex string. >> +should not be sent by default; @value{GDBN} requests it with either >> +the @ref{QThreadEvents} or @ref{QThreadOptions} packets. See also >> +@ref{thread create event} above. @var{AA} is formatted as a >> +big-endian hex string. >> >> @item N >> There are no resumed threads left in the target. In other words, even >> @@ -42875,6 +42891,11 @@ same thread. @value{GDBN} does not enable this feature unless the >> stub reports that it supports it by including @samp{QThreadEvents+} in >> its @samp{qSupported} reply. >> >> +This packet always enables/disables event reporting for all threads of >> +all processes under control of the remote stub. For per-thread >> +control of optional event reporting, see the @ref{QThreadOptions} >> +packet. >> + >> Reply: >> @table @samp >> @item OK >> @@ -42891,6 +42912,94 @@ the stub. >> Use of this packet is controlled by the @code{set remote thread-events} >> command (@pxref{Remote Configuration, set remote thread-events}). >> >> +@anchor{QThreadOptions} >> +@item QThreadOptions@r{[};@var{options}@r{[}:@var{thread-id}@r{]]}@dots{} >> +@cindex thread options, remote request >> +@cindex @samp{QThreadOptions} packet >> + >> +For each inferior thread, the last @var{options} in the list with a >> +matching @var{thread-id} are applied. Any options previously set on a >> +thread are discarded and replaced by the new options specified. >> +Threads that do not match any @var{thread-id} retain their >> +previously-set options. Thread IDs are specified using the syntax >> +described in @ref{thread-id syntax}. If multiprocess extensions >> +(@pxref{multiprocess extensions}) are supported, options can be >> +specified to apply to all threads of a process by using the >> +@samp{p@var{pid}.-1} form of @var{thread-id}. Options with no >> +@var{thread-id} apply to all threads. Specifying no options is an >> +error. >> + >> +@var{options} is the bitwise @code{OR} of the following values. All >> +values are given in hexadecimal representation. > > I think it is implied, but would be must better explicitly stated, that > it is valid to send 0 in order to clear all options. > I did the following tweak, put here because that's where I felt the text could be ambiguous otherwise (as in: 'is "no options" the same as zero?' kind of ambiguous): @samp{p@var{pid}.-1} form of @var{thread-id}. Options with no -@var{thread-id} apply to all threads. Specifying no options is an -error. +@var{thread-id} apply to all threads. Specifying no options value is +an error. Zero is a valid value.