From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 1B77C3861939 for ; Wed, 11 Oct 2023 21:56:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B77C3861939 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3084721860; Wed, 11 Oct 2023 21:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697061393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zGDMq5DAAFKT/6qmElZ5lcBC+B4/jQXuRdlFTf58UJ4=; b=1S4AZ+Qsm9pc8TdD32SMT/sxyPBSDTYOLJAfSwHdhj4plXJxQtHvmiwvT3Tfvs5YaIB1X6 XJ7SvMQW+fFAfBUCTrKgZr3KbC/6CdPrActy5jMkZg9uQhzsMSVVN3WNrnNLcfQ3b0eXAb EvtQH3vbvGH0NenLVXtIU5n7uM8XLjo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697061393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zGDMq5DAAFKT/6qmElZ5lcBC+B4/jQXuRdlFTf58UJ4=; b=OHhP+qYFhoGUtESq1GCYZfIygQgNfw47fy66E5P/DAxUsE3EqCdiySnb4OvriC+n5X/HUb qtKE2FCqEG01ZxCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C0B0138EF; Wed, 11 Oct 2023 21:56:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qH+IBREaJ2WzQAAAMHmgww (envelope-from ); Wed, 11 Oct 2023 21:56:33 +0000 Message-ID: Date: Wed, 11 Oct 2023 23:56:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] [gdb/cli] Allow source highlighting to be interrupted Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231011134247.3832-1-tdevries@suse.de> <87jzrtt7lp.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87jzrtt7lp.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.10 X-Spamd-Result: default: False [-1.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.01)[44.95%]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/11/23 19:02, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Breakpoint 1, Solution::numOfSubarrays (this=0x7fffffffdbcf, arr=...) at test.cpp:56 > Tom> ^Cwarning: Couldn't highlight source file /data/vries/gdb/test.cpp: Interrupted > Tom> 56 return (int) t; > Tom> (gdb) > Tom> ... > > Tom> RFC: is the warning a good idea, or overkill? > > I'm on the fence, Hmm, I just realized that the line can be (and in the setup I'm looking at actually is) highlighted, not by GNU source-hightlight but by python pygments, which makes the warning in the current form confusing. > though I guess if it can't be done it might be nice if > gdb kept track of this and just didn't try highlighting that file again. > Sounds doable. Thanks, - Tom