From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [pushed] gdb: constify target_stack::is_pushed
Date: Mon, 3 Oct 2022 09:33:57 -0400 [thread overview]
Message-ID: <ac139ecd-58df-0742-fbfe-1e25e885d4fc@polymtl.ca> (raw)
In-Reply-To: <87zgehiyz5.fsf@tromey.com>
On 2022-09-29 18:42, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> The target_ops parameters here can be made const.
>
> Simon> - bool target_is_pushed (target_ops *t)
> Simon> + bool target_is_pushed (const target_ops *t)
>
> Seems like this one could also be const-qualified, like this one is:
>
> Simon> + bool is_pushed (const target_ops *t) const
> Simon> { return at (t->stratum ()) == t; }
Thanks, I just pushed a patch that does that.
Simon
prev parent reply other threads:[~2022-10-03 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 20:42 Simon Marchi
2022-09-29 22:42 ` Tom Tromey
2022-10-03 13:33 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac139ecd-58df-0742-fbfe-1e25e885d4fc@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).