From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 71E383858C36 for ; Tue, 27 Feb 2024 09:35:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71E383858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 71E383858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709026551; cv=none; b=w9D4+B3ZMi4qoOlKWkSZd72Xd8R0iVY8y+CSSdNSXg/Brv/H4UzQrrr6bFUy884dvyph5Al97DqMf+VdFP6Ra0cYfM5rExlgqCNcOvtL81lC90qH4nMvfEyOSAjMKP+9XCq3eca/Otez479lbazRo5uRJKohmj2c0SwiBe2ziLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709026551; c=relaxed/simple; bh=+2LznkJgI1ETzCCKhoyRoAYX5xPTdYgIN9YleT0frYE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=hC3WhZ+cLOV5LeMVzT9Ra2LW3W60kynEttz/5D9zs6XZ+xulL71+9GaYcZspKPQMAbwofDad00JGWmsvhSCk6YEPfNNorlifl8eAXV7gbqRwK4G60Lb2ayDnmi03GDbmsDMKlRhcs/tm5/0SsGYkmD3s5fUr4t2ZEEIgEC5rY/k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 82AC52203E; Tue, 27 Feb 2024 09:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709026548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yoZQO2bKyjRVr0UMR4p+GEDNJKWFBzrXO3fkea5SM4o=; b=jPPGPuJwUtGPCToNDDkrm61mUTRT7KltCkzP+GdsroAKBF0WY3/vRv3vPr+ZFVrdyhG06Q uufDIZfgdhS1ABBKzB0k89ag1/1oR1VQNlhC50XxbDIdNyzT6UXVPyjDdnglE/6ovvrjPi S3KSETJrXRFyYOM6fHvDVw72NXzj1nk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709026548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yoZQO2bKyjRVr0UMR4p+GEDNJKWFBzrXO3fkea5SM4o=; b=UUn5v3LmnYxvnxsPfx8vLjEUKhFygkM6qoWWUh8LfnU/N9b7w5Dt/0VO1ykHTM0R0I6tUw 5dcRnNDbvH5Ru8Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709026548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yoZQO2bKyjRVr0UMR4p+GEDNJKWFBzrXO3fkea5SM4o=; b=jPPGPuJwUtGPCToNDDkrm61mUTRT7KltCkzP+GdsroAKBF0WY3/vRv3vPr+ZFVrdyhG06Q uufDIZfgdhS1ABBKzB0k89ag1/1oR1VQNlhC50XxbDIdNyzT6UXVPyjDdnglE/6ovvrjPi S3KSETJrXRFyYOM6fHvDVw72NXzj1nk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709026548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yoZQO2bKyjRVr0UMR4p+GEDNJKWFBzrXO3fkea5SM4o=; b=UUn5v3LmnYxvnxsPfx8vLjEUKhFygkM6qoWWUh8LfnU/N9b7w5Dt/0VO1ykHTM0R0I6tUw 5dcRnNDbvH5Ru8Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 61CCA13A67; Tue, 27 Feb 2024 09:35:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0PKWFvSs3WUVdAAAD6G6ig (envelope-from ); Tue, 27 Feb 2024 09:35:48 +0000 Message-ID: Date: Tue, 27 Feb 2024 10:35:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] Fix formatting buglet in python.c Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240220-py-simple-exc-v3-0-a2825caa4b74@adacore.com> <20240220-py-simple-exc-v3-2-a2825caa4b74@adacore.com> From: Tom de Vries In-Reply-To: <20240220-py-simple-exc-v3-2-a2825caa4b74@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jPPGPuJw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UUn5v3Lm X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.31 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.81)[99.20%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -4.31 X-Rspamd-Queue-Id: 82AC52203E X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 20:46, Tom Tromey wrote: > python.c has a split string that is missing a space. There's also a > stray backslash in this code. LGTM. Reviewed-By: Tom de Vries Thanks, - Tom > --- > gdb/python/python.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/python/python.c b/gdb/python/python.c > index 7b0997c8d52..b2e8f244f85 100644 > --- a/gdb/python/python.c > +++ b/gdb/python/python.c > @@ -1601,7 +1601,7 @@ gdbpy_print_stack (void) > /* An error occurred computing the string representation of the > error message. */ > gdb_printf (gdb_stderr, > - _("Error occurred computing Python error" \ > + _("Error occurred computing Python error " > "message.\n")); > PyErr_Clear (); > } >