From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>,
Christina Schimpe <christina.schimpe@intel.com>,
gdb-patches@sourceware.org
Cc: eliz@gnu.org, blarsen@redhat.com
Subject: Re: [PATCH v5 1/1] gdb, breakpoint: add breakpoint location debugging logs
Date: Wed, 5 Jul 2023 12:18:00 -0400 [thread overview]
Message-ID: <ac3b0d5b-cabb-fd8d-684b-7caf6a26776c@simark.ca> (raw)
In-Reply-To: <87ttukkkcu.fsf@redhat.com>
Some more nits, in addition to what Andrew said.
>> +/* Return a textual version of breakpoint BL describing number, location and
>> + address. */
>> +
>> +static std::string
>> +breakpoint_location_address_str (const bp_location* bl)
Space before the asterisk.
In the description, it would be more precise to say "of breakpoint
location BL" instead of "of breakpoint BL". However, you can be more
concise and say just "of BL", it's clear from its type that BL is a
breakpoint location.
The patch LGTM with that (plus what Andrew said) fixed, no need to re-post.
Simon
next prev parent reply other threads:[~2023-07-05 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 8:14 [PATCH v5 0/1] Add " Christina Schimpe
2023-06-12 8:14 ` [PATCH v5 1/1] gdb, breakpoint: add " Christina Schimpe
2023-07-03 8:33 ` [PING][PATCH " Schimpe, Christina
2023-07-03 11:58 ` Eli Zaretskii
2023-07-03 12:01 ` Schimpe, Christina
2023-07-04 11:05 ` [PATCH " Andrew Burgess
2023-07-05 16:18 ` Simon Marchi [this message]
2023-08-09 9:07 ` Schimpe, Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3b0d5b-cabb-fd8d-684b-7caf6a26776c@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
--cc=christina.schimpe@intel.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).