From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37307 invoked by alias); 26 Jun 2018 15:11:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37298 invoked by uid 89); 26 Jun 2018 15:11:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:527, notified X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jun 2018 15:11:52 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5QFBkVG030481 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 26 Jun 2018 11:11:50 -0400 Received: by simark.ca (Postfix, from userid 112) id E36501EF28; Tue, 26 Jun 2018 11:11:45 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6CEFD1E08D; Tue, 26 Jun 2018 11:11:45 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 26 Jun 2018 15:11:00 -0000 From: Simon Marchi To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Notify about breakpoint modification when enabling/disabling single location In-Reply-To: <20180531085633.7830-1-jan.vrany@fit.cvut.cz> References: <20180531085633.7830-1-jan.vrany@fit.cvut.cz> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00614.txt.bz2 On 2018-05-31 04:56, Jan Vrany wrote: > When a single breakpoint location enableness was modified by a CLI > command, > observers were not notified about it. This issue is now fixed. > > gdb/ChangeLog: > > * breakpoint.c (enable_disable_bp_num_loc): Notify observers. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-breakpoint-location-ena-dis.cc: New file. > * gdb.mi/mi-breakpoint-location-ena-dis.exp: New file. LGTM, thanks. Simon