From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9ABBF3858D35 for ; Thu, 5 Jan 2023 07:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9ABBF3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672904926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dWqAicMohrTTqX3rx2Jj5JaiE9qpvkoei/VNGnMMTCE=; b=Cg+bG+izAWRBI0S//w/rLoth89/Nq4/yxG7RITfRPm9GrbZTWnJx+3bq6uh/T5w2qCuYzI 6mHYiRuf/us1gQhkf1PC+sqZudrPBGUR0ANBqtUwAfNiUWTa8+6tpZoYZY/dRFbefFggiU br9jFy92ZEiYvKcJ/0RQaHCXyUx1UqI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-553-1Ks2TxHtM3-MUBKusQ8IVw-1; Thu, 05 Jan 2023 02:48:45 -0500 X-MC-Unique: 1Ks2TxHtM3-MUBKusQ8IVw-1 Received: by mail-wm1-f72.google.com with SMTP id a6-20020a05600c224600b003d1f3ed49adso196980wmm.4 for ; Wed, 04 Jan 2023 23:48:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dWqAicMohrTTqX3rx2Jj5JaiE9qpvkoei/VNGnMMTCE=; b=HwUYXxL1He/kK31rDUwcWtgBqtNesBLrexWpDiDhu8ddFlhQY46s31pz01XlREC9+4 aiJoxbSBn2ax4W4CuQiiJ544GRlIFwNbjJK/zeCcVDj6Urwpfj6o+8cPxLHQyru9MfQ5 VJGbjQBsan5n1qvC4cycqATf2xbfKeHfvZio9jeRc4A3q8M8bv1AvT8S5gWadWFnPIvW jGrudKtDpjmFhGcaPLYAX8XhROlHn5V2KHA6EKblvK0F31ho3hJKCLXv5kw2VJZNeZPa cqCHXUdfWiHAXM0yC4zxVf4UtHn5LnjdM/yz0d/UU9OU43LInAm2uzdp5V3+08GccMtF fTQw== X-Gm-Message-State: AFqh2ko7o+BORb8fr9jc3O5b427SUhGIoENQg68ESmysBjukPnIBU8ln vFL+hTkZeDfhfVbwSgA2Q0xAnE0kLBmH4nDLGNbj+BTb2oU48uCGxXkYVgT4tVgmVe9uPjjKVMQ /TmGXcnk6vRyDin2kXv7Vpw== X-Received: by 2002:a05:600c:4e90:b0:3cf:894f:964b with SMTP id f16-20020a05600c4e9000b003cf894f964bmr36959978wmq.16.1672904923970; Wed, 04 Jan 2023 23:48:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXvZ/BEkO4a1VgszHY56k2frid4EKhiN4rzuBZBosjfmydqkcCpgwyqTkgyQ53JvC3YD9bDblA== X-Received: by 2002:a05:600c:4e90:b0:3cf:894f:964b with SMTP id f16-20020a05600c4e9000b003cf894f964bmr36959968wmq.16.1672904923686; Wed, 04 Jan 2023 23:48:43 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id q187-20020a1c43c4000000b003c6c182bef9sm1654531wma.36.2023.01.04.23.48.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 23:48:43 -0800 (PST) Message-ID: Date: Thu, 5 Jan 2023 08:48:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] Add type to expression dump of symbol To: Tom Tromey , gdb-patches@sourceware.org References: <20230102172813.997882-1-tromey@adacore.com> From: Bruno Larsen In-Reply-To: <20230102172813.997882-1-tromey@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/01/2023 18:28, Tom Tromey via Gdb-patches wrote: > I recently had cause to dump some expressions from gdb. I got output > like this: > > Operation: BINOP_GTR > Operation: OP_VAR_VALUE > Block symbol: > Symbol: small_value > Block: 0x39b4c20 > Operation: OP_LONG > Operation: OP_LONG > Type: int > Constant: 0x0000000000000014 > > This is ok, but it would have been handy to see the type of the > symbol. This ptach adds this information. s/ptach/patch Other than that, seems useful and introduces no regressions, so Reviewed-By: Bruno Larsen -- Cheers, Bruno