From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 2FFEA3858C50 for ; Fri, 17 Mar 2023 23:05:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FFEA3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5291F21AA7; Fri, 17 Mar 2023 23:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679094344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wWIFVwhMRDvb37RE0h23n57dwaD9e/OhaWwtFB4LhsM=; b=i85WLrXrrYVFGn03U+zoBeYlfLoamBRWX3+C5eKm13dbwu4lvRsOpjWhcDldTxZVMOjOyw 2fvGV2Txb1QFCRrPstUn8DmmGyb9gsatNWRbzgyVqluiMsfUiKJeqh62j1QXdMfpF+wHOM +SOrm8oDxjjz9trx/qwtaM5a2fV+srU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679094344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wWIFVwhMRDvb37RE0h23n57dwaD9e/OhaWwtFB4LhsM=; b=quAdmIPTaJATYpNq3W4L7Ps4VYbXx2G+3u1LrxDdaLUTLXeQ/S5v+VNvBrZPjLp1xHXKf5 edD/m2T5A26yx4CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2EF971346F; Fri, 17 Mar 2023 23:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m1lhCkjyFGT+XQAAMHmgww (envelope-from ); Fri, 17 Mar 2023 23:05:44 +0000 Message-ID: Date: Sat, 18 Mar 2023 00:05:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2 ver2] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp To: Ulrich Weigand , "gdb-patches@sourceware.org" , Bruno Larsen , "cel@us.ibm.com" , "pedro@palves.net" References: <7a494157-494f-6adf-d533-bf373b0f054f@redhat.com> <71aa635593df0677811afb85409aa190bcfa4f6a.camel@us.ibm.com> <15864a6b87b25c93e99a28149f23138267735f2a.camel@us.ibm.com> <041f62e9f26fd4a536bc90c34f072985582e6237.camel@de.ibm.com> <46c2c756475ba5923d7eed97996632a08285dd42.camel@us.ibm.com> <65861786-069e-53a1-ca17-a525b6629c95@suse.de> <5be0c849abeef84d34a6ff255fb2705ca5dcb035.camel@us.ibm.com> <27caff18b9e133583ba147a21cdd997a0a580828.camel@de.ibm.com> <4195b7b1fe6120e71310a1036841f141b9d1199e.camel@us.ibm.com> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/17/23 18:19, Ulrich Weigand wrote: > Carl Love wrote: > >> I have updated gdb/infrun.c per the comments from Ulrich to remove >> "unnecessary" code and format changes to make the diff as minimal as I >> can. There are no functional changes in these changes. >> >> The patch has been retested on PowerPC to make sure there are no >> regressions. >> >> Please let me know if this version of this patch (second in the series) >> is acceptable. Thanks. > > This version is OK. I'm running into these regressions on x86_64-linux: ... Running /data/vries/gdb/src/gdb/testsuite/gdb.reverse/finish-precsave.exp ... FAIL: gdb.reverse/finish-precsave.exp: reverse finish from long_long_func FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: long_func backward FAIL: gdb.reverse/finish-precsave.exp: reverse finish from long_func FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: int_func backward FAIL: gdb.reverse/finish-precsave.exp: reverse finish from int_func FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: short_func backward FAIL: gdb.reverse/finish-precsave.exp: reverse finish from short_func FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: char_func backward FAIL: gdb.reverse/finish-precsave.exp: reverse finish from char_func FAIL: gdb.reverse/finish-precsave.exp: continue to breakpoint: void_func backward FAIL: gdb.reverse/finish-precsave.exp: reverse finish from void_func Running /data/vries/gdb/src/gdb/testsuite/gdb.btrace/tailcall.exp ... FAIL: gdb.btrace/tailcall.exp: reverse-finish.1 FAIL: gdb.btrace/tailcall.exp: reverse-step.2 FAIL: gdb.btrace/tailcall.exp: next.1 FAIL: gdb.btrace/tailcall.exp: reverse-next.1 FAIL: gdb.btrace/tailcall.exp: step.1 FAIL: gdb.btrace/tailcall.exp: finish.2 FAIL: gdb.btrace/tailcall.exp: reverse-step.3 FAIL: gdb.btrace/tailcall.exp: finish.3 Running /data/vries/gdb/src/gdb/testsuite/gdb.mi/mi-reverse.exp ... FAIL: gdb.mi/mi-reverse.exp: reverse finish from callme (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse next to get over the call to do_nothing (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse step to callee1 (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse step to callee2 (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse step to callee3 (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse step to callee4 (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse-step-instruction at callee4 (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse-next-instruction at callee4 (unknown output after running) FAIL: gdb.mi/mi-reverse.exp: reverse-continue at callee3 (unknown output after running) Running /data/vries/gdb/src/gdb/testsuite/gdb.btrace/step.exp ... FAIL: gdb.btrace/step.exp: replay: reverse-finish.1 FAIL: gdb.btrace/step.exp: replay: reverse-next.2 FAIL: gdb.btrace/step.exp: replay: reverse-finish.2 (GDB internal error) Running /data/vries/gdb/src/gdb/testsuite/gdb.reverse/until-precsave.exp ... FAIL: gdb.reverse/until-precsave.exp: reverse-finish from marker2 FAIL: gdb.reverse/until-precsave.exp: reverse-advance to final return of factorial FAIL: gdb.reverse/until-precsave.exp: reverse-until to entry of factorial Running /data/vries/gdb/src/gdb/testsuite/gdb.reverse/finish-reverse.exp ... FAIL: gdb.reverse/finish-reverse.exp: reverse finish from long_long_func FAIL: gdb.reverse/finish-reverse.exp: continue to breakpoint: long_func backward FAIL: gdb.reverse/finish-reverse.exp: reverse finish from long_func FAIL: gdb.reverse/finish-reverse.exp: continue to breakpoint: int_func backward FAIL: gdb.reverse/finish-reverse.exp: reverse finish from int_func FAIL: gdb.reverse/finish-reverse.exp: continue to breakpoint: short_func backward FAIL: gdb.reverse/finish-reverse.exp: reverse finish from short_func FAIL: gdb.reverse/finish-reverse.exp: continue to breakpoint: char_func backward FAIL: gdb.reverse/finish-reverse.exp: reverse finish from char_func FAIL: gdb.reverse/finish-reverse.exp: continue to breakpoint: void_func backward FAIL: gdb.reverse/finish-reverse.exp: reverse finish from void_func Running /data/vries/gdb/src/gdb/testsuite/gdb.reverse/finish-reverse-next.exp ... FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1 LEP call from LEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP entry point function call from LEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2, at b = 5, call from LEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1 LEP call from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 5, from function body FAIL: gdb.reverse/finish-reverse-next.exp: function1 GEP call call from GEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP entry point function call from GEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50, call from GEP FAIL: gdb.reverse/finish-reverse-next.exp: function1 GEP call call from GEP again FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP entry point function call from GEP again FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50, call from GEP again FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1 GEP call, from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP call from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50 from function body Running /data/vries/gdb/src/gdb/testsuite/gdb.btrace/tailcall-only.exp ... FAIL: gdb.btrace/tailcall-only.exp: reverse-step FAIL: gdb.btrace/tailcall-only.exp: up ... Thanks, - Tom