From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id A2E80385737B for ; Tue, 14 Jun 2022 17:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2E80385737B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 6E87673290; Tue, 14 Jun 2022 17:49:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMwsn2R4Jz3jwZ; Tue, 14 Jun 2022 17:49:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655228941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+ZSPyCf+a9UGLrEgLqffCigZXtpUTAW1HgBhGMAe5M=; b=vjP9Z4252bkNEdU2wwXfIurJ7V+QGNVblUOPKJLI6bdn5avxl1HyladDWJRI26AXH6UMc2 JPgE2Toyd923V9+/GtpdqrAQpZDRZq0qzAGL3uUr7HixUPtV9vshjwvloBz+Fe3/YtpZuq 6RzAdQn460sTj73xFiLkjYiurM04ya5XucXY7raKZMZSEd0UFRiwoC8JL/WPRCrX5jJkfr iCGCEG7xzvBQTESjV5fnlxMoFAtsryMh5UDUKqHz8Uf2fN4mdrF4aZb2w3FVw8sDl9OVgg av/JTUL/THoJtIJTjaSN74WimPKyDTQ5600cRJ0wlZRofmYFfl7iHKgMoos89Q== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id DC24CB171; Tue, 14 Jun 2022 17:49:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 14 Jun 2022 10:48:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [Ping v3] [PATCH 0/4] Add AMX support. Content-Language: en-US To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655228941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+ZSPyCf+a9UGLrEgLqffCigZXtpUTAW1HgBhGMAe5M=; b=D8ISO/uvSDL+NXXwD2j0DPNSDEkSpI+UTHVr56J3de4ot0a7AqF3eUfkgQLrK8ZVk8FZa8 CqbUaU0SsnniOpR0IiLxYX1GkJvzsjQsz0UYps8nZjVIp5FQI2xjQHqRfHsAzx6/+dCIYR pwkfPISq6PBb82ds+l4wtCAFMgqsclSYIZBqi7TB2ptsaZ2O2hrgQJBY+LdVg2UIu4aQU6 Sl24q5BJyTciQbqIdI9Of9HaBWS1JRPnC2Oxd8NBvhlN09enjpBW9vR5LHRxgJUm9W1DGW Mxkgbu0FytX01Ts9PKwzNY2EWbacJBAuGuqboqy7xN/pvJA/o1NGqytDeSy/ew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655228941; a=rsa-sha256; cv=none; b=UbUFmPBpV24fxoli+J9hrGLzCgeXqQF+JO4y5o9fZV5F/O0PXMGDnM6qSC8ERoK2nKU+Qz O+LYnlBJwKHWhIbakF0soaJ1r/dKbwr7MuY8iYiwq0fcp2mG/kYowDmg8od4hF+OGbHJhl EONmXH6KffSNCigfUmOlt+1bWG1vOAJuwMDSThj1CbbAsdriV+TGxNwpGOoPjIgJom96Ej wMvUaDVw+J10vG62uUbrYQ7/MRoAhrvz65rqUka3sTHThoFIVborb1nyEFFm2yn+i5SWnq Ezk7KofQphuBJNr2/HxfE+lfaVYc/YTt9FK7ot8t9LS9b25l5mgsmzSm+Ht6BA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2022 17:49:10 -0000 I can't formally approve, but this looks fine to me. I think it's fine to push this in first and then I can rebase and update my XSAVE layout series for this and work on getting it merged after this. On 6/14/22 2:33 AM, Willgerodt, Felix via Gdb-patches wrote: > *ping* v3 > > Thanks, > Felix > >> -----Original Message----- >> From: Willgerodt, Felix >> Sent: Dienstag, 7. Juni 2022 11:14 >> To: gdb-patches@sourceware.org >> Subject: RE: [Ping v2] [PATCH 0/4] Add AMX support. >> >> *ping* >> >> Thanks, >> Felix >> >>> -----Original Message----- >>> From: Willgerodt, Felix >>> Sent: Freitag, 20. Mai 2022 16:41 >>> To: gdb-patches@sourceware.org >>> Subject: [Ping] [PATCH 0/4] Add AMX support. >>> >>> *Ping* >>> >>> I have adapted all of Eli's comments on documentation locally. >>> They were all straightforward, so I didn't post a v2 for those yet. >>> >>> Regards, >>> Felix >>> >>>> -----Original Message----- >>>> From: Willgerodt, Felix >>>> Sent: Freitag, 6. Mai 2022 14:12 >>>> To: gdb-patches@sourceware.org >>>> Cc: Willgerodt, Felix >>>> Subject: [PATCH 0/4] Add AMX support. >>>> >>>> Hi all, >>>> >>>> This is a series to add support for the new Advanced Matrix Extensions >>>> (AMX) >>>> on x86 architectures. They add new registers that require modeling >>>> in GDB and gdbserver. >>>> >>>> Happy about any feedback! >>>> >>>> Regards, >>>> Felix >>>> >>>> Aleksandar Paunovic (1): >>>> gdb: define int512 and uint512 as built-in types. >>>> >>>> Felix Willgerodt (3): >>>> gdb, gdbserver: Add AMX registers. >>>> gdb, gdbserver: Allocate only a sane amount of buffer when fetching >>>> registers. >>>> gdb: Clear tilecfg.start_row for any PC modification. >>>> >>>> gdb/amd64-linux-nat.c | 2 + >>>> gdb/amd64-linux-tdep.c | 36 +- >>>> gdb/amd64-tdep.c | 214 +++++++++++- >>>> gdb/amd64-tdep.h | 2 + >>>> gdb/arch/amd64.c | 4 + >>>> gdb/doc/gdb.texinfo | 44 +++ >>>> gdb/features/Makefile | 1 + >>>> gdb/features/i386/64bit-amx.c | 60 ++++ >>>> gdb/features/i386/64bit-amx.xml | 36 ++ >>>> gdb/gdbtypes.c | 4 + >>>> gdb/gdbtypes.h | 2 + >>>> gdb/i386-linux-tdep.c | 2 + >>>> gdb/i386-linux-tdep.h | 2 +- >>>> gdb/i386-tdep.c | 321 +++++++++++++++++- >>>> gdb/i386-tdep.h | 122 ++++++- >>>> gdb/i387-tdep.c | 156 ++++++++- >>>> gdb/i387-tdep.h | 8 + >>>> gdb/target-descriptions.c | 6 + >>>> gdb/testsuite/gdb.arch/amd64-amx-corefile.exp | 113 ++++++ >>>> gdb/testsuite/gdb.arch/amd64-amx-startrow.c | 122 +++++++ >>>> gdb/testsuite/gdb.arch/amd64-amx-startrow.exp | 91 +++++ >>>> gdb/testsuite/gdb.arch/amd64-amx.c | 173 ++++++++++ >>>> gdb/testsuite/gdb.arch/amd64-amx.exp | 231 +++++++++++++ >>>> gdb/testsuite/lib/gdb.exp | 67 ++++ >>>> gdbserver/i387-fp.cc | 70 +++- >>>> gdbserver/linux-amd64-ipa.cc | 2 +- >>>> gdbserver/linux-i386-ipa.cc | 2 +- >>>> gdbserver/linux-x86-low.cc | 4 +- >>>> gdbserver/linux-x86-tdesc.cc | 3 + >>>> gdbserver/linux-x86-tdesc.h | 3 +- >>>> gdbserver/server.h | 2 +- >>>> gdbsupport/tdesc.cc | 2 + >>>> gdbsupport/tdesc.h | 2 + >>>> gdbsupport/x86-xstate.h | 33 +- >>>> 34 files changed, 1901 insertions(+), 41 deletions(-) >>>> create mode 100644 gdb/features/i386/64bit-amx.c >>>> create mode 100644 gdb/features/i386/64bit-amx.xml >>>> create mode 100644 gdb/testsuite/gdb.arch/amd64-amx-corefile.exp >>>> create mode 100644 gdb/testsuite/gdb.arch/amd64-amx-startrow.c >>>> create mode 100755 gdb/testsuite/gdb.arch/amd64-amx-startrow.exp >>>> create mode 100644 gdb/testsuite/gdb.arch/amd64-amx.c >>>> create mode 100755 gdb/testsuite/gdb.arch/amd64-amx.exp >>>> >>>> -- >>>> 2.34.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 -- John Baldwin