Re: [PATCH 15/16] gdb: make cmd_list_element var an optional union

[Simon Marchi <simon.marchi@polymtl.ca>]

> +  setting_variable v { .bool_var = &param_value->boolval };
> +  return pascm_param_value (type, v, arg_pos, func_name);

I thought about doing something like this, my only itch is that
declaration of `setting_variable v`.  It is confusing to see it just
setting the bool_var field, regardless of the actual type.  I understand
it works because the pointer value is the same in any case, but to be
pedantic it should be something like:

  setting_variable v;
  switch (type)
    {
    case var_boolean:
      v.bool_var = &param_value->boolval;
      break;
    case var_auto_boolean:
      v.auto_boolean_var = &param_value->autoboolval;
      break;
    // and so on
    }

It's a bit more verbose, but it's written only once, and it's not like
new var types are added every week.

I would be fine changing my patch to use your approach with that change,
if you are.

Simon