From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by sourceware.org (Postfix) with ESMTPS id 996623842AC0 for ; Tue, 15 Nov 2022 12:15:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 996623842AC0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id v1so23895533wrt.11 for ; Tue, 15 Nov 2022 04:15:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cbbuJ0fpkJIJTUubhqHVAJS4ne1rfBPBnQQPUm5hbGU=; b=reDSEtR0eVBq4l7Tm6ZNfcCmoCcHDliCmbb2YUjB1g1Gen2vR/4o2y2c+p5URPDIOx 93zczzutKGgZ9iZC2vuhTpQVJr+dXxTdpKCvuJaIBcblnLppUj6JmikblFHmhRSPR7yJ UYm5N9F6OQkGYZu8ngP8dnmStczEFKlBUuwiVQmiIpQkNVE3yVaPC3hZ8fY7CVLU9gww w1/ddUmRNAM7JFiap1ucb+yM+k2MyJphjBEUQDQcSmyLSROQ/g79JDgJ8+uRNlC/e/f4 nZeT5wG9BHoCJiB/O83MdeMIB/g6cx0+Ad5veOHY9QPog65dSVXOixUvWoZN5f/XEGH5 sOQA== X-Gm-Message-State: ANoB5pnXvhbI2mb7UdDbgJKG182N/FDlsUU5/ldpC40RpdcVN43R027R Lr/qER/aUQ3Tznn7IxEaA1DQXtjH7sw= X-Google-Smtp-Source: AA0mqf7feIbSLjIrqhLFsudvDPEiriMm1d7i/SMlIrS8PN+MhK7gTu/O/FQo13xokvI+AJOTmgLa7w== X-Received: by 2002:adf:d851:0:b0:236:6089:cc5e with SMTP id k17-20020adfd851000000b002366089cc5emr10407165wrl.118.1668514556442; Tue, 15 Nov 2022 04:15:56 -0800 (PST) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id q13-20020adfea0d000000b0023677fd2657sm12122147wrm.52.2022.11.15.04.15.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 04:15:55 -0800 (PST) Subject: Re: [PATCH] Add "set style tui-current-position on|off" default to off To: Andrew Burgess , gdb-patches@sourceware.org Cc: Phi Debian References: <38b5d874-cdf2-50e7-dc76-aed3fee20334@redhat.com> <3011c306-2c6c-228f-07eb-95d3ff560942@redhat.com> <314644177.1902979.1592236099059@mail.yahoo.com> <07772538-b41f-49e2-43c9-c6cb8831050b@redhat.com> <87366whyvk.fsf@tromey.com> <00ed105b-6fe6-f554-f1d8-7f361695687e@redhat.com> <73b40c12-cbd2-336a-3258-96f5134843a3@redhat.com> <875yfga5r7.fsf@redhat.com> From: Pedro Alves Message-ID: Date: Tue, 15 Nov 2022 12:15:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <875yfga5r7.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-11-15 10:09 a.m., Andrew Burgess wrote: > I'd be interested to see this patch merged. I took a look through the > code changes, and it all looks good to me. > > Attached below is a rebase of Pedro's patch. I've gone through the docs > and comments to mention assembly highlighting, which has been added to > GDB since this patch was originally written. > > I've left the author email as 'Pedro Alves ' as this > reflects where/when the patch was written, but I can update this to > anything more suitable upon request. > > Pedro (or anyone) - any objections if I merge this patch? LGTM. Thanks for pushing this forward. Pedro Alves