From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/4] Remove some symtab accessors
Date: Thu, 7 Apr 2022 13:08:14 -0400 [thread overview]
Message-ID: <ae14918b-7861-399c-7f1a-04888fd9c5a3@polymtl.ca> (raw)
In-Reply-To: <87tub5c7fc.fsf@tromey.com>
On 2022-04-07 10:08, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> I am playing with symtabs currently and was a bit confused with some
> Simon> accessors that make some things appear as if they are symtab-specific,
> Simon> when they are not. These accessors forward to the symtab's parent
> Simon> objects. I don't think they are very useful and just hide the real
> Simon> object structure of GDB, so I suggest removing them.
>
> I don't really mind the current code, but I also am fine with your
> change, and the patches all looked fine to me.
>
> Tom
Thanks, pushed.
Simon
prev parent reply other threads:[~2022-04-07 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 14:42 Simon Marchi
2022-04-06 14:42 ` [PATCH 1/4] gdb: remove symtab::dirname Simon Marchi
2022-04-06 14:42 ` [PATCH 2/4] gdb: remove symtab::blockvector Simon Marchi
2022-04-06 14:42 ` [PATCH 3/4] gdb: remove symtab::objfile Simon Marchi
2022-04-06 14:42 ` [PATCH 4/4] gdb: remove symtab::pspace Simon Marchi
2022-04-07 14:08 ` [PATCH 0/4] Remove some symtab accessors Tom Tromey
2022-04-07 17:08 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae14918b-7861-399c-7f1a-04888fd9c5a3@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).